[Crash-utility] [PATCH v2 0/6] bt fixes and cleanup for ppc64

Hari Bathini hbathini at linux.ibm.com
Mon Jul 4 10:53:31 UTC 2022



On 04/07/22 2:14 pm, HAGIO KAZUHITO(萩尾 一仁) wrote:
> 
> On 2022/07/04 14:25, Hari Bathini wrote:
>> This patch series fixes a couple of issues with bt on ppc64 and also
>> does some code cleanup.
>>
>> Patch #1 fixes the broken '-S' option on ppc64. The next patch changes
>> h/w interrupt stack allocation to dynamic as this field remains unused
>> in most cases. The next patch renames ppc64_paca_init() function to
>> ppc64_paca_percpu_offset_init() to reflect what the function actually
>> does. Patch#4 adds support to process backtrace when the stack pointer
>> is in an emergency SP. The next patch adds support to print emergency
>> stack data. And the last patch ensures a variable is used instead of
>> machdep->machspec to optimize code and improve readability.
>>
>> Changes in v2:
>> * Print "(unused)", if hwintrstack is not being used.
>> * Avoid using variable length array for paca_ptrs.
>> * With 'mach' command, print emergency stack data by default
>>     (no special option).
> 
> Thank you for the v2.
> There are a few typos but no need to respin so for the series:

Thanks a lot!

> Acked-by: Kazuhito Hagio <k-hagio-ab at nec.com>
> 
> They are nice improvements!

Yeah. Hopefully, should help with some complex issues...

Thanks
Hari



More information about the Crash-utility mailing list