<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <meta http-equiv="Content-Type" content="text/html;charset=UTF-8"> <title></title> </head> <body> Olaf Hering wrote: <blockquote type="cite" cite="mid20060320083340.GA27034@suse.de"> <pre wrap=""> On Fri, Mar 17, David Wilder wrote: </pre> <blockquote type="cite"> <pre wrap="">This patch add sparsemem support to crash. Please comment. Per-node memory display functions (kmem -n) are not yet working for sparsemem kernels. This will come in a later patch. This patch applies to 4.0-2.21. </pre> </blockquote> <pre wrap=""> This patch is incomplete. missing defines for ia64, s390, s390x pick some random numbers. --- defs.h | 11 +++++++++++ 1 file changed, 11 insertions(+) Index: crash-4.0-2.18/defs.h =================================================================== --- crash-4.0-2.18.orig/defs.h +++ crash-4.0-2.18/defs.h @@ -2024,6 +2024,7 @@ struct load_module { #define KERNEL_CACHED_BASE ((ulong)KERNEL_CACHED_REGION << REGION_SHIFT) #define _SECTION_SIZE_BITS 30 +#define _MAX_PHYSADDR_BITS 50 /* FIXME */ #define _MAX_PHYSMEM_BITS 50 /* @@ -2256,6 +2257,11 @@ struct efi_memory_desc_t { #define TIF_SIGPENDING (2) +/* FIXME */ +#define _SECTION_SIZE_BITS 24 +#define _MAX_PHYSADDR_BITS 44 +#define _MAX_PHYSMEM_BITS 44 + #endif /* S390 */ #ifdef S390X @@ -2276,6 +2282,11 @@ struct efi_memory_desc_t { #define TIF_SIGPENDING (2) +/* FIXME */ +#define _SECTION_SIZE_BITS 24 +#define _MAX_PHYSADDR_BITS 44 +#define _MAX_PHYSMEM_BITS 44 + #endif /* S390X */ #ifdef PLATFORM -- Crash-utility mailing list <a class="moz-txt-link-abbreviated" href="mailto:Crash-utility@redhat.com">Crash-utility@redhat.com</a> <a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/crash-utility">https://www.redhat.com/mailman/listinfo/crash-utility</a> </pre> </blockquote> Probably ought to add some alpha processor #defines to keep that arch building as well. Hmmm -- for that matter, I don't see the _MAX_PHYSADDR_BITS being used anywhere other than setting each per-processor machdep->max_physaddr_bits(), and by extension, in the MAX_PHYSADDR_BITS() macro. But that macro doesn't get used anywhere? Also, none of the *_PAE additions get used. Dave </body> </html>