<!doctype html public "-//w3c//dtd html 4.0 transitional//en"> <html> <tt>Hi Castor,</tt><tt></tt> <tt>Can you re-create your latest patch so that it applies</tt> <tt>like the one it's replacing?</tt><tt></tt> <tt>Here's the patch you're replacing:</tt><tt></tt> <tt>$ lsdiff crash-4.0-3.14-sym.patch</tt> <tt>crash-4.0-3.14/defs.h</tt> <tt>crash-4.0-3.14/gdb-6.1/gdb/symtab.c</tt> <tt>crash-4.0-3.14/kernel.c</tt> <tt>crash-4.0-3.14/symbols.c</tt> <tt>$</tt><tt></tt> <tt>$ patch -p1 --dry-run < crash-4.0-3.14-sym.patch</tt> <tt>patching file defs.h</tt> <tt>patching file gdb-6.1/gdb/symtab.c</tt> <tt>patching file kernel.c</tt> <tt>patching file symbols.c</tt> <tt>$</tt><tt></tt> <tt>Here's your latest:</tt><tt></tt> <tt>$ lsdiff crash-4.0-3.14-sym.1.patch</tt> <tt>$</tt><tt></tt> <tt>$ patch -p1 --dry-run < crash-4.0-3.14-sym.1.patch</tt> <tt>can't find file to patch at input line 2</tt> <tt>Perhaps you used the wrong -p or --strip option?</tt> <tt>The text leading up to this was:</tt> <tt>--------------------------</tt> <tt>|diff -r -x Makefile crash-4.0-3.14/defs.h crash-4.0-3.14-sym/defs.h</tt> <tt>--------------------------</tt> <tt>File to patch:</tt> <tt>Skip this patch? [y]</tt> <tt>Skipping patch.</tt> <tt>1 out of 1 hunk ignored</tt> <tt>can't find file to patch at input line 6</tt> <tt>Perhaps you used the wrong -p or --strip option?</tt> <tt>The text leading up to this was:</tt> <tt>--------------------------</tt> <tt>|diff -r -x Makefile crash-4.0-3.14/gdb-6.1/gdb/symtab.c crash-4.0-3.14-sym/gdb-6.1/gdb/symtab.c</tt> <tt>--------------------------</tt> <tt>File to patch:</tt> <tt>Skip this patch? [y]</tt> <tt>Skipping patch.</tt> <tt>1 out of 1 hunk ignored</tt> <tt>can't find file to patch at input line 17</tt> <tt>Perhaps you used the wrong -p or --strip option?</tt> <tt>The text leading up to this was:</tt> <tt>--------------------------</tt> <tt>|diff -r -x Makefile crash-4.0-3.14/kernel.c crash-4.0-3.14-sym/kernel.c</tt> <tt>--------------------------</tt> <tt>File to patch:</tt> <tt>Skip this patch? [y]</tt> <tt>Skipping patch.</tt> <tt>1 out of 1 hunk ignored</tt> <tt>can't find file to patch at input line 44</tt> <tt>Perhaps you used the wrong -p or --strip option?</tt> <tt>The text leading up to this was:</tt> <tt>--------------------------</tt> <tt>|diff -r -x Makefile crash-4.0-3.14/symbols.c crash-4.0-3.14-sym/symbols.c</tt> <tt>--------------------------</tt> <tt>File to patch:</tt> <tt>Skip this patch? [y]</tt> <tt>Skipping patch.</tt> <tt>11 out of 11 hunks ignored</tt> <tt>$</tt> <tt></tt> <tt></tt> Castor Fu wrote: <blockquote TYPE=CITE> Oops, I found some problems with that version... Some data was not alwaysinitialized and there were some things which were just lucky to work.I've attached a new patch.Sorry about that folks, castor <blockquote dir=ltr style="MARGIN-RIGHT: 0px"> <div class="OutlookMessageHeader" dir="ltr">-----Original Message----- From: crash-utility-bounces@redhat.com [<A HREF="mailto:crash-utility-bounces@redhat.com">mailto:crash-utility-bounces@redhat.com</A>]On Behalf Of Castor Fu Sent: Monday, December 04, 2006 11:16 AM To: Discussion list for crash utility usage, maintenance and development Subject: RE: [Crash-utility] modules and data / bss initialization </div> I'm attaching a revised patch against 4.0-3.14... This shouldwork a bit better as I no longer make assumptions about the orderingof symbols, it's less whiny, and I even compiled with with -Werror sothose sign-extension problems should be gone.Thanks for the feedback! <blockquote dir=ltr style="MARGIN-RIGHT: 0px"> <div class="OutlookMessageHeader" dir="ltr">-----Original Message----- From: crash-utility-bounces@redhat.com [<A HREF="mailto:crash-utility-bounces@redhat.com">mailto:crash-utility-bounces@redhat.com</A>]On Behalf Of Dave Anderson Sent: Friday, December 01, 2006 11:46 AM To: Discussion list for crash utility usage, maintenance and development Subject: Re: [Crash-utility] modules and data / bss initialization </div> Castor Fu wrote: <blockquote TYPE="CITE">I don't think this made it out earlier...Here's a fix. I've also added something so 'MODULES_IN_CWD' will work on 2.6since modules will end with .koI hope this looks good to others....</blockquote> <tt>Hi Castor,</tt> <tt>Upon quick testing with RHEL4 and RHEL5 x86_64 kernels,</tt> <tt>this patch certainly looks promising...</tt> <tt>Although I don't particularly care to see these messages:</tt> <tt>ffffffff8810ae80 serio_raw 41157 /lib/modules/2.6.18-1.2747.el5/kernel/drivers/input/serio/serio_raw.ko</tt> <tt>ffffffff8811b580 uhci_hcd 59353 /lib/modules/2.6.18-1.2747.el5/kernel/drivers/usb/host/uhci-hcd.ko</tt> <tt>ffffffff88130b00 shpchp 73069 /lib/modules/2.6.18-1.2747.el5/kernel/drivers/pci/hotplug/shpchp.ko</tt> <tt>unexpected sym __key.10825 8814a180 sec .bss offset e180 mod_base 8813c000</tt> <tt>XXX sym __key.10825 @ 8814a180 bfd val 0 section .bss</tt> <tt>unexpected sym __key.10826 8814a180 sec .bss offset e180 mod_base 8813c000</tt> <tt>XXX sym __key.10826 @ 8814a180 bfd val 0 section .bss</tt> <tt>ffffffff88141f80 i2c_core 57793 /lib/modules/2.6.18-1.2747.el5/kernel/drivers/i2c/i2c-core.ko</tt> <tt>I would think they could be CRASHDEBUG(1)'d, couldn't they?</tt> <tt>Plus, those error messages will clip 64-bit values as shown</tt> <tt>above.</tt> <tt>I'm also presuming that the new add-symbol-file operation will</tt> <tt>harmlessly take a "0" mod_data_start, mod_rodata_start or</tt> <tt>mod_bss_start address argument; seemingly it does, since several</tt> <tt>of my test modules have 0 as one or more of those start addresses.</tt> <tt>Anyway, I also would be interested in the experiences of others</tt> <tt>on the list who are using different architectures and kernel</tt> <tt>versions.</tt> <tt>Thanks,</tt> <tt> Dave</tt> </blockquote> </blockquote> <pre WRAP> <hr WIDTH="90%" SIZE=4>-- Crash-utility mailing list Crash-utility@redhat.com <a href="https://www.redhat.com/mailman/listinfo/crash-utility">https://www.redhat.com/mailman/listinfo/crash-utility</a></pre> </blockquote> </html>