<html> <head> <style></style></head> <body class='hmmessage'><div dir='ltr'><div>Dave,</div><div><br></div><div>I reviewed all you changes. It looked good to me.</div><div><br></div><div>It seemed your patch had some trailing whitespace issues.</div><div><br>Just FYI. </div><div><br></div><div><div>$ git apply ~/files_v5.patch</div><div>/home/oliver/files_v5.patch:35: trailing whitespace.</div><div>" %s> files -c 1954",</div><div>/home/oliver/files_v5.patch:259: trailing whitespace.</div><div> count, nrpages);</div><div>/home/oliver/files_v5.patch:362: trailing whitespace.</div><div> mkstring(buf2, MAX(VADDR_PRLEN, strlen("I_MAPPING")),</div><div>warning: 3 lines add whitespace errors.</div></div><div><br></div><div><br></div><br><br><div><hr id="stopSpelling">From: yang_oliver@hotmail.com<br>To: crash-utility@redhat.com<br>Date: Wed, 1 Jul 2015 00:00:12 +0000<br>Subject: Re: [Crash-utility] [PATCH v4] files: support dump file memory mapping<br><br> <style></style> <div dir="ltr"><br><br><div>Date: Tue, 30 Jun 2015 17:02:53 -0400<br>From: anderson@redhat.com<br>To: crash-utility@redhat.com<br>Subject: Re: [Crash-utility] [PATCH v4] files: support dump file memory mapping<br><br><pre> <br> <br>----- Original Message -----<br>> > <br>> > So in the interest of expediency, what I will do is this:<br>> > <br>> > (1) change "files -m" to "files -c"<br>> > (2) drop the MAPPING column from "files -p"<br>> > (3) reword the description of the two options in the help page to emphasize<br>> > that the NRPAGES count and page dumps are page cache counts/page-dumps<br>> > (4) either figure out a way to compress the help page example outputs into<br>> > 80 columns, or drop the files -p example completely<br>> > <br>> > I'll post the patch this afternoon and you can verify it tonight.<br>> <br>> Sure, I will. Thanks for your helps and comments.<br>> I hope I can do better for my next patch. :-)<br>> <br>> <br> <br>Hi Oliver,<br> <br>I've attached the patch for your review. In addition to the items listed<br>above, I also made a few other minor changes to better handle some error <br>conditions I ran into while testing the patch, I renamed a few functions and<br>macros to be more related to their actual purpose, globally exposed just the<br>single-page dump callback function, and made it return a legitimate return value.<br>(And there may be other minor changes that I can't remember.) <br> <br>Let me know what you think about the changes, and if we're in agreement,<br>I'll check it in tomorrow.<br><br></pre><pre><br></pre><pre><br></pre></div> </div> <br>-- Crash-utility mailing list Crash-utility@redhat.com https://www.redhat.com/mailman/listinfo/crash-utility</div> </div></body> </html>