<html><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"></head><body><div>I'm on vacation until next Tuesday, but it's certainly easier to just enter:</div><div><br></div><div> zone.min_slab_pages <address></div><div><br></div><div>I can't see what's going on with the p command, but I'll take a look next week.</div><div><br></div><div>Dave</div><div><br></div><div><br></div><div><br></div><div id="composer_signature"><div style="font-size:85%;color:#575757" dir="auto">Sent from my Verizon, Samsung Galaxy smartphone</div></div><div><br></div><div style="font-size:100%;color:#000000"><div>-------- Original message --------</div><div>From: Dave Wysochanski <dwysocha@redhat.com> </div><div>Date: 5/15/19 12:40 PM (GMT-05:00) </div><div>To: "Discussion list for crash utility usage, maintenance and development" <crash-utility@redhat.com> </div><div>Subject: [Crash-utility] Problem with crash-7.2.6 and certain print commands? </div><div><br></div></div>We rebuilt crash with the tarball from:<br>http://people.redhat.com/anderson/crash-7.2.6.tar.gz<br><br>I thought initially something had gone wrong with the tarball, so I<br>redownloaded it myself and did an md5sum. This checked out ok. I<br><br>We had a report that the print command was broken, specifically this<br>failed:<br><br>crash> pd ((struct zone *)0xffff901e3ffda000)->min_slab_pages<br>p: invalid option -- '>'<br>p: invalid option -- 'm'<br>p: invalid option -- 'i'<br>p: invalid option -- 'n'<br>p: invalid option -- '_'<br>p: invalid option -- 's'<br>p: invalid option -- 'l'<br>p: invalid option -- 'a'<br>p: invalid option -- 'b'<br>p: invalid option -- '_'<br>p: invalid option -- 'p'<br>p: invalid option -- 'a'<br>p: invalid option -- 'g'<br>p: invalid option -- 'e'<br>p: invalid option -- 's'<br>Usage:<br> p [-x|-d][-u] [expression | symbol[:cpuspec]]<br>Enter "help p" for details.<br><br><br><br>We thought we didn't have this commit:<br><br>commit 977c3a20a053eaff5b1f0c95246f88cd66712f27<br>Author: Dave Anderson <anderson@redhat.com><br>Date: Thu Jan 24 13:36:02 2019 -0500<br><br> Fix for the "p" command if the expression contains more than one<br> opening parenthesis character and a minus/dash sign. Without the<br> patch, the minus/dash sign will get dropped from the command prior<br> to it being passed on to gdb for evaluation, and the command will<br> fail with the message "p: gdb request failed: <expression>",<br> where the <expression> string will not contain the minus/dash sign.<br> (anderson@redhat.com)<br><br>diff --git a/symbols.c b/symbols.c<br>index 5f77e27..6814723 100644<br>--- a/symbols.c<br>+++ b/symbols.c<br>@@ -1,8 +1,8 @@<br> /* symbols.c - core analysis suite<br> *<br> * Copyright (C) 1999, 2000, 2001, 2002 Mission Critical Linux, Inc.<br>- * Copyright (C) 2002-2018 David Anderson<br>- * Copyright (C) 2002-2018 Red Hat, Inc. All rights reserved.<br>+ * Copyright (C) 2002-2019 David Anderson<br>+ * Copyright (C) 2002-2019 Red Hat, Inc. All rights reserved.<br> *<br> * This program is free software; you can redistribute it and/or modify<br> * it under the terms of the GNU General Public License as published by<br>@@ -7201,7 +7201,7 @@ cmd_p(void)<br> *(cpuspec-1) = ':';<br> }<br> <br>- process_gdb_output(concat_args(buf1, 0, TRUE), radix,<br>+ process_gdb_output(concat_args(buf1, 0, FALSE), radix,<br> sp ? sp->name : NULL, do_load_module_filter);<br> }<br><br><br><br>But this was reverted again in:<br><br>commit e082c372c7f1a782b058ec359dfbbbee0f0b6aad<br>Author: Dave Anderson <anderson@redhat.com><br>Date: Thu Jan 31 12:08:43 2019 -0500<br><br> Fix for the internal parse_line() utility function to account for<br> embedded sets of parentheses, which may be used for expressions that<br> are passed to gdb by the "p" command. Without the patch, expressions<br> containing embedded sets of parentheses are broken up into multiple<br> argument tokens instead of just one. The previous commit has been<br> reverted by this one.<br> (anderson@redhat.com)<br><br>diff --git a/symbols.c b/symbols.c<br>index 6814723..e73e735 100644<br>--- a/symbols.c<br>+++ b/symbols.c<br>@@ -7201,7 +7201,7 @@ cmd_p(void)<br> *(cpuspec-1) = ':';<br> }<br> <br>- process_gdb_output(concat_args(buf1, 0, FALSE), radix,<br>+ process_gdb_output(concat_args(buf1, 0, TRUE), radix,<br> sp ? sp->name : NULL, do_load_module_filter);<br> }<br> <br><br>--<br>Crash-utility mailing list<br>Crash-utility@redhat.com<br>https://www.redhat.com/mailman/listinfo/crash-utility<br><br></body></html>