<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> </head> <body dir="ltr"> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Hi,</div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br> </div> <div id="appendonsend"></div> <blockquote style="border-left: 3px solid rgb(200, 200, 200); border-top-color: rgb(200, 200, 200); border-right-color: rgb(200, 200, 200); border-bottom-color: rgb(200, 200, 200); padding-left: 1ex; margin-left: 0.8ex; color: rgb(102, 102, 102);"> <div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)"> Hi,<span style="font-family: Calibri, sans-serif; font-size: 14.6667px;">Hatayama</span><br> </div> <div dir="ltr" style="font-size:12pt; color:#000000; background-color:#FFFFFF; font-family:Calibri,Arial,Helvetica,sans-serif"> <div><br> </div> <div>Since zram page not a existing page,so we can't use vtop find exactly physical address,so gcore have to make a little change for this.gcore patch i've already sent in previous mail<br> </div> </div> </blockquote> <div><span></span></div> <div>Please don't remove uvtop_quiet(), which is necessary. The reason is to avoid some bug in crash utility in the past as written in the comment in uvtop_quiet().</div> <div><br> </div> <div>Looking at the following stanza, the necessary change is to add a call of try_zram_decompress() when uvtop_quiet() returns false but paddr is non-zero.</div> <div><br> </div> <div> <a href="https://github.com/crash-utility/crash/commit/b12bdd36cf7caad24957c0b8c030001321ab2df4#diff-997c8aaa6bf9a3d9f77e5cab843cd9a6R2290" id="LPNoLP212551">https://github.com/crash-utility/crash/commit/b12bdd36cf7caad24957c0b8c030001321ab2df4#diff-997c8aaa6bf9a3d9f77e5cab843cd9a6R2290</a></div> <br> <div>defs.h belongs to crash utility. Please don't post change of defs.h to crash gcore command.</div> <div><br> </div> <blockquote style="border-left: 3px solid rgb(200, 200, 200); border-top-color: rgb(200, 200, 200); border-right-color: rgb(200, 200, 200); border-bottom-color: rgb(200, 200, 200); padding-left: 1ex; margin-left: 0.8ex; color: rgb(102, 102, 102);"> <div dir="ltr" style="font-size:12pt; color:#000000; background-color:#FFFFFF; font-family:Calibri,Arial,Helvetica,sans-serif"> <div></div> <div><br> </div> <div>I've answered your question in the previous email about exactly kernel commit in aarch64 stack,please refer to below change<br> </div> <div>The latest two changes are attached,please review.<br> </div> </div> </blockquote> <div>Thanks. I'll review this later.</div> <blockquote style="border-left: 3px solid rgb(200, 200, 200); border-top-color: rgb(200, 200, 200); border-right-color: rgb(200, 200, 200); border-bottom-color: rgb(200, 200, 200); padding-left: 1ex; margin-left: 0.8ex; color: rgb(102, 102, 102);"> <div dir="ltr" style="font-size:12pt; color:#000000; background-color:#FFFFFF; font-family:Calibri,Arial,Helvetica,sans-serif"> <div></div> <div><br> </div> <div><span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)">commit 34be98f4944f99076f049a6806fc5f5207a755d3</span><br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)">Author: Ard Biesheuvel <ard.biesheuvel@linaro.org></span><br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)">Date: Thu Jul 20 17:15:45 2017 +0100</span><br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> arm64: kernel: remove {THREAD,IRQ_STACK}_START_SP</span><br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> For historical reasons, we leave the top 16 bytes of our task and IRQ</span><br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> stacks unused, a practice used to ensure that the SP can always be</span><br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> masked to find the base of the current stack (historically, where</span><br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> thread_info could be found).</span><br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> However, this is not necessary, as:</span><br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> * When an exception is taken from a task stack, we decrement the SP by</span><br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> S_FRAME_SIZE and stash the exception registers before we compare the</span><br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> SP against the task stack. In such cases, the SP must be at least</span><br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> S_FRAME_SIZE below the limit, and can be safely masked to determine</span><br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> whether the task stack is in use.</span><br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> * When transitioning to an IRQ stack, we'll place a dummy frame onto the</span><br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> IRQ stack before enabling asynchronous exceptions, or executing code</span><br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> we expect to trigger faults. Thus, if an exception is taken from the</span><br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> IRQ stack, the SP must be at least 16 bytes below the limit.</span><br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> * We no longer mask the SP to find the thread_info, which is now found</span><br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> via sp_el0. Note that historically, the offset was critical to ensure</span><br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> that cpu_switch_to() found the correct stack for new threads that</span><br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> hadn't yet executed ret_from_fork().</span><br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> Given that, this initial offset serves no purpose, and can be removed.</span><br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> This brings us in-line with other architectures (e.g. x86) which do not</span><br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> rely on this masking.</span><br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org></span><br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> [Mark: rebase, kill THREAD_START_SP, commit msg additions]</span><br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> Signed-off-by: Mark Rutland <mark.rutland@arm.com></span><br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> Reviewed-by: Will Deacon <will.deacon@arm.com></span><br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> Tested-by: Laura Abbott <labbott@redhat.com></span><br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> Cc: Catalin Marinas <catalin.marinas@arm.com></span><br style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> <span style="color:rgb(33,33,33); font-family:"Segoe UI","Segoe WP","Segoe UI WPC",Tahoma,Arial,sans-serif; font-size:13.3333px; background-color:rgb(255,255,255)"> Cc: James Morse <james.morse@arm.com></span></div> </div> </blockquote> <div dir="ltr" style="font-size:12pt; color:#000000; background-color:#FFFFFF; font-family:Calibri,Arial,Helvetica,sans-serif"> <div><br> </div> </div> </body> </html>