<div dir="ltr">Hi Burr,<div><br></div><div class="gmail_extra"><div class="gmail_quote">On Fri, Apr 7, 2017 at 4:09 AM, Burr Sutter <span dir="ltr"><<a href="mailto:bsutter@redhat.com" target="_blank">bsutter@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="gmail-">On Thu, Apr 6, 2017 at 1:31 PM, Budh Gurung <span dir="ltr"><<a href="mailto:bgurung@redhat.com" target="_blank">bgurung@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi Burr,<div><br></div><div>Comments inline.</div><div class="gmail_extra"><br><div class="gmail_quote"><span>On Thu, Apr 6, 2017 at 9:16 PM, Burr Sutter <span dir="ltr"><<a href="mailto:bsutter@redhat.com" target="_blank">bsutter@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">1) Fails on Windows 10 (clean machine, newly installed VirtualBox)<div><a href="https://github.com/minishift/minishift/issues/695" target="_blank">https://github.com/minishift/m<wbr>inishift/issues/695</a></div></div></blockquote><div><br></div></span><p style="box-sizing:border-box;margin-top:0px;margin-bottom:16px;color:rgb(36,41,46);font-family:-apple-system,blinkmacsystemfont,"segoe ui",helvetica,arial,sans-serif,"apple color emoji","segoe ui emoji","segoe ui symbol";font-size:14px">I doubt you actually hit by this issue <a href="https://issues.jboss.org/browse/CDK-70" style="box-sizing:border-box;color:rgb(3,102,214);background-color:transparent" target="_blank">https://issues.jboss.org<wbr>/browse/CDK-70</a>. </p><p style="box-sizing:border-box;margin-top:0px;margin-bottom:16px;color:rgb(36,41,46);font-family:-apple-system,blinkmacsystemfont,"segoe ui",helvetica,arial,sans-serif,"apple color emoji","segoe ui emoji","segoe ui symbol";font-size:14px">This happens when you don't have <code style="box-sizing:border-box;font-family:sfmono-regular,consolas,"liberation mono",menlo,courier,monospace;font-size:11.9px;padding:0.2em 0px;margin:0px;background-color:rgba(27,31,35,0.0470588);border-radius:3px">ssh.exe</code> binary set in your <em style="box-sizing:border-box">PATH</em>.</p><div><span style="color:rgb(36,41,46);font-family:-apple-system,blinkmacsystemfont,"segoe ui",helvetica,arial,sans-serif,"apple color emoji","segoe ui emoji","segoe ui symbol";font-size:14px">We have observed that installing</span><span style="color:rgb(36,41,46);font-family:-apple-system,blinkmacsystemfont,"segoe ui",helvetica,arial,sans-serif,"apple color emoji","segoe ui emoji","segoe ui symbol";font-size:14px"> </span><a href="https://sourceforge.net/projects/sshwindows/" style="font-family:-apple-system,blinkmacsystemfont,"segoe ui",helvetica,arial,sans-serif,"apple color emoji","segoe ui emoji","segoe ui symbol";font-size:14px;background-color:transparent;box-sizing:border-box;color:rgb(3,102,214)" target="_blank">OpenSSH for Windows</a><span style="color:rgb(36,41,46);font-family:-apple-system,blinkmacsystemfont,"segoe ui",helvetica,arial,sans-serif,"apple color emoji","segoe ui emoji","segoe ui symbol";font-size:14px"> </span><span style="color:rgb(36,41,46);font-family:-apple-system,blinkmacsystemfont,"segoe ui",helvetica,arial,sans-serif,"apple color emoji","segoe ui emoji","segoe ui symbol";font-size:14px">resolve this issue.</span></div><div><span style="color:rgb(36,41,46);font-family:-apple-system,blinkmacsystemfont,"segoe ui",helvetica,arial,sans-serif,"apple color emoji","segoe ui emoji","segoe ui symbol";font-size:14px"><br></span></div><div><span style="color:rgb(36,41,46);font-family:-apple-system,blinkmacsystemfont,"segoe ui",helvetica,arial,sans-serif,"apple color emoji","segoe ui emoji","segoe ui symbol";font-size:14px">Investigation is undergoing to know the actual reason.</span></div></div></div></div></blockquote><div><br></div></span><div>That sounds like it.  I am out of CDK on Windows testing time for several days but I might be able to try  a beta 4 when it becomes available.</div><span class="gmail-"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span><div><span style="color:rgb(36,41,46);font-family:-apple-system,blinkmacsystemfont,"segoe ui",helvetica,arial,sans-serif,"apple color emoji","segoe ui emoji","segoe ui symbol";font-size:14px"></span> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><br></div><div>2) Need an admin/admin user</div><div> <a href="https://github.com/minishift/minishift/issues/696" target="_blank">https://github.com/minishift/<wbr>minishift/issues/696</a></div></div></blockquote><div><br></div></span><div> This I am not sure as we given 'developer' user a 'sudoer' role by default and all </div><div>admin operations can be run with "--as system:admin". </div></div></div></div></blockquote><div><br></div></span><div>Right, but as a human, I need to be able to login to the console as admin :-)</div><div><br></div><div>Damn humans/users.</div><span class="gmail-"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div></div><div>3) Disk size?</div><div><a href="https://github.com/minishift/minishift/issues/697" target="_blank">https://github.com/minishift/m<wbr>inishift/issues/697</a></div></div></blockquote><div><br></div></span><div>With `--disk-size` option in "start" command.</div><div>Check in more detail here </div><div><a href="https://docs.openshift.org/latest/minishift/command-ref/minishift_start.html" target="_blank">https://docs.openshift.org/lat<wbr>est/minishift/command-ref/mini<wbr>shift_start.html</a></div></div></div></div></blockquote><div><br></div></span><div>Why is that not a "minishift config set disk-size 20gb" like memory and CPUs? </div></div></div></div></blockquote><div><br></div><div>You can run exactly same command except 20gb and it will work :).  </div><div><br></div><div>"gb" is not used as unit here. Valid units are b, k, m or g maps to Bytes, KB, MB, or GB respectively.</div><div><br></div><div>Actual command is "minishift config set disk-size 20g"</div><div><br></div><div>In fact, you can use "config set" command to all the options/properties listed here </div><div><br></div><div><a href="https://docs.openshift.org/latest/minishift/command-ref/minishift_config.html">https://docs.openshift.org/latest/minishift/command-ref/minishift_config.html</a></div><div><br></div><div>Hope it helps. </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="gmail-"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><span><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><br></div><div>4) --metrics true does not seem to work</div><div><a href="https://github.com/minishift/minishift/issues/698" target="_blank">https://github.com/minishift/m<wbr>inishift/issues/698</a></div></div></blockquote><div><br></div></span><div>We had similar issue here <a href="https://github.com/minishift/minishift/issues/606" target="_blank">https://github.com/minish<wbr>ift/minishift/issues/606</a> .   </div></div></div></div></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>5) config set and view are out of order</div><div><a href="https://github.com/minishift/minishift/issues/699" target="_blank">https://github.com/minishift/m<wbr>inishift/issues/699</a></div></div></blockquote><div><br></div></span><div>We couldn't find the value in the order of config values. </div><div>Would definitely like to hear if ordering config values achieve any</div><div>specific use case here. </div></div></div></div></blockquote><div><br></div></span><div>As a user, I expect 2 ordering schemes:</div><div>1) The order is consistent for every time I use "minishift config view", right not the order jumps around based on what was last "set this" or  "set that".  Basically the order is currently "random" from what I can tell</div><div>or</div></div></div></div></blockquote><div><br></div><div>1st approach has been used as part of version 1.0.0-rc1. You might want to look into it.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>2) The order based on my various "set this" and "set that".  So if I use "set memory 6000" then "set cpus 2" and then "set vm-driver virtualbox" then "config view" should display those same settings in that same order.</div><div><br></div><div>Either approach would work for me :-) </div></div></div></div></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="gmail-"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div></div><div>6) version should be available prior to setup-cdk</div><div><a href="https://github.com/minishift/minishift/issues/700" target="_blank">https://github.com/minishift/m<wbr>inishift/issues/700</a></div></div></blockquote><div><br></div></span><div>AFAIR, we did that in order detect whether binary is CDK binary</div><div>or upstream minishift binary. We might need to find another way</div><div>if we really want to see version before "setup-cdk".</div><div> </div><div>We checks the existance of cdk marker file in CDK binary which contains </div><div>information like cdk version (also used by devstudio).</div><div>"setup-cdk" step creates that marker file and hence you</div><div>get expected version after that.</div><div><br></div><div>We don't do this check in upstream minishift binary. </div><div> <br></div></div></div></div></blockquote></span><span class="gmail-"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><br></div></div>
<br>______________________________<wbr>_________________<br>
Devtools mailing list<br>
<a href="mailto:Devtools@redhat.com" target="_blank">Devtools@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/devtools" rel="noreferrer" target="_blank">https://www.redhat.com/mailman<wbr>/listinfo/devtools</a><br>
<br></blockquote></div><br></div><div class="gmail_extra">Regards,<div>Budh Ram Gurung</div><div>Software Engineer - Devtools</div></div></div>
</blockquote></span></div><br></div></div>
</blockquote></div><br></div><div class="gmail_extra"><br></div><div class="gmail_extra">Regards,<div>Budh Ram Gurung</div><div>Software Engineer - Devtools</div></div></div>