[dm-devel] [PATCH v2] multipath: add find_multipaths feature.

Benjamin Marzinski bmarzins at redhat.com
Thu Sep 1 14:21:06 UTC 2011


On Thu, Sep 01, 2011 at 07:57:20AM -0500, Benjamin Marzinski wrote:
> On Thu, Sep 01, 2011 at 09:14:23AM +0200, Christophe Varoqui wrote:
> > On mer., 2011-08-31 at 21:55 -0500, Benjamin Marzinski wrote:
> > > This adds a new default feature, find_multipaths. When this is set to yes,
> > > multipath will no longer try to create a multipath device for every
> > > non-blacklisted device. Instead, it will only create a device when one of
> > > three conditions are met.
> > > 
> > > 1. Three are at least two non-blacklisted paths with the same wwid
> > > 2. The user manually forces the creation, by specifying a device with the
> > >    multipath command.
> > > 3. A path has the same wwid as a multipath device that was previously crreated
> > >    (even if that multipath device doesn't currently exist).
> > > 
> > Hannes,
> > 
> > this patch implements complex semantics and mis-use /etc to store
> > variable data (/run was suggested as a replacement). Though I realize
> > the benefits, I'm not at ease merging it.
> 
> This will add wwids to the wwids file at the same times that new bindings
> get added to the bindings file. We decided to move the bindings file to
> /etc/multipath/bindings because it caused problems during bootup, if
> /var/run was not mounted.  This will have the same problems where you
> will be writing to a file that eventually gets mounted over.  So I am
> against using /var/run

although it looks like the systemd folks have made /run a tmpfs
filesystem, and /var/run a pointer to it (at least in Fedora), so I
guess I'm not opposed to moving things back to /var/run anymore.

-Ben

> 
> -Ben
> 
> > 
> > Mike Snitzer pushed for its inclusion, but I don't remember your
> > commenting. Would your care to ?
> > 
> > Regards,
> > 
> > -- 
> > Christophe Varoqui
> > OpenSVC - Tools to scale
> > http://www.opensvc.com/
> > 
> > --
> > dm-devel mailing list
> > dm-devel at redhat.com
> > https://www.redhat.com/mailman/listinfo/dm-devel
> 
> --
> dm-devel mailing list
> dm-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel




More information about the dm-devel mailing list