[dm-devel] blk-mq request allocation stalls
Mike Snitzer
snitzer at redhat.com
Mon Jan 12 19:11:39 UTC 2015
On Mon, Jan 12 2015 at 1:35pm -0500,
Keith Busch <keith.busch at intel.com> wrote:
> On Mon, 12 Jan 2015, Keith Busch wrote:
> >Oh, let's look at "__blk_rq_prep_clone". dm calls that after
> >blk_get_request() for the blk-mq based multipath types and overrides the
> >destinations cmd_flags with the source's even though the source was not
> >allocated from a blk-mq based queue, much less a shared tag.
>
> Untested patch. This will also preserve the failfast cmd_flag dm-mpath
> set after allocating.
Ah, good point. The failfast flag would get cleared with the patch I
just proposed (unless REQ_FAILFAST_TRANSPORT was added to
REQ_PRESERVE_CLONE_MASK).
Anyway, I'm happy to see this implemented however you guys think is
best. I think I like Keith's patch better than mine.
More information about the dm-devel
mailing list