[dm-devel] [PATCH 2/5] remove unnecessary memset
Benjamin Marzinski
bmarzins at redhat.com
Thu Nov 18 00:10:35 UTC 2021
On Tue, Nov 16, 2021 at 09:59:41PM +0800, lixiaokeng wrote:
> MALLOC will set memory zero. memset is unnecessary.
> Remove it.
>
> Signed-off-by: Lixiaokeng <lixiaokeng at huawei.com>
Reviewed-by: Benjamin Marzinski <bmarzins at redhat.com>
> ---
> libmultipath/log.c | 1 -
> multipathd/waiter.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/libmultipath/log.c b/libmultipath/log.c
> index 10fa32cd..f41efb5b 100644
> --- a/libmultipath/log.c
> +++ b/libmultipath/log.c
> @@ -57,7 +57,6 @@ static int logarea_init (int size)
> FREE(la);
> return 1;
> }
> - memset(la->start, 0, size);
>
> la->empty = 1;
> la->end = la->start + size;
> diff --git a/multipathd/waiter.c b/multipathd/waiter.c
> index bbe6c2a1..f74b395a 100644
> --- a/multipathd/waiter.c
> +++ b/multipathd/waiter.c
> @@ -33,7 +33,6 @@ static struct event_thread *alloc_waiter (void)
> struct event_thread *wp;
>
> wp = (struct event_thread *)MALLOC(sizeof(struct event_thread));
> - memset(wp, 0, sizeof(struct event_thread));
>
> return wp;
> }
> --
More information about the dm-devel
mailing list