[dm-devel] [PATCH v3 00/11] Split libmultipath and libmpathutil

[Benjamin Marzinski]

On Mon, Aug 22, 2022 at 11:22:49PM +0200, mwilck at suse.com wrote:
> From: Martin Wilck <mwilck at suse.com>
> 
> The CI found a few more glitches in my v2 patch set. Not reposting
> the entire set here, just the changed patches.

For all except 01/11 & 10/11:
Reviewed-by: Benjamin Marzinski <bmarzins at redhat.com>

> 
> Changes v2->v3:
>   fix compilation errors on Alpine an CI errors.
> 
> 
> Hannes Reinecke (1):
>   multipathd: replace libreadline with getline()
> 
> Martin Wilck (10):
>   .gitignore: ignore generated ABI files
>   libmultipath: move all reservation key functions to prkey.c
>   libmultipath: always set _GNU_SOURCE
>   multipath-tools: Makefile: fix dependencies for "install" target
>   libmultipath checkers/prioritizers: search for includes in
>     libmultipath
>   libmultipath: remove weak attribute for {get,put}_multipath_config
>   libmultipath: split off libmpathutil
>   multipathc: add new interactive client program
>   multipathd: exec multipathc in interactive mode
>   multipathd: fix incompatible pointer type error with libedit
> 
>  .gitignore                                   |   3 +
>  Makefile                                     |   8 +-
>  Makefile.inc                                 |   5 +-
>  libmpathpersist/Makefile                     |   6 +-
>  libmpathutil/Makefile                        |  70 +++++
>  {libmultipath => libmpathutil}/debug.c       |   0
>  {libmultipath => libmpathutil}/debug.h       |   0
>  libmpathutil/globals.c                       |  12 +
>  libmpathutil/globals.h                       |  39 +++
>  libmpathutil/libmpathutil.version            | 122 +++++++++
>  {libmultipath => libmpathutil}/log.c         |   0
>  {libmultipath => libmpathutil}/log.h         |   0
>  {libmultipath => libmpathutil}/log_pthread.c |   0
>  {libmultipath => libmpathutil}/log_pthread.h |   0
>  {libmultipath => libmpathutil}/parser.c      |   0
>  {libmultipath => libmpathutil}/parser.h      |   2 +-
>  {libmultipath => libmpathutil}/strbuf.c      |   0
>  {libmultipath => libmpathutil}/strbuf.h      |   0
>  {libmultipath => libmpathutil}/time-util.c   |   0
>  {libmultipath => libmpathutil}/time-util.h   |   0
>  {libmultipath => libmpathutil}/util.c        |  32 ---
>  {libmultipath => libmpathutil}/util.h        |   2 -
>  {libmultipath => libmpathutil}/uxsock.c      |   0
>  {libmultipath => libmpathutil}/uxsock.h      |   0
>  {libmultipath => libmpathutil}/vector.c      |   0
>  {libmultipath => libmpathutil}/vector.h      |   0
>  libmpathvalid/Makefile                       |   6 +-
>  libmultipath/Makefile                        |  17 +-
>  libmultipath/checkers/Makefile               |   7 +-
>  libmultipath/checkers/directio.c             |   4 +-
>  libmultipath/checkers/emc_clariion.c         |   2 +-
>  libmultipath/checkers/hp_sw.c                |   4 +-
>  libmultipath/checkers/rdac.c                 |   2 +-
>  libmultipath/checkers/tur.c                  |   8 +-
>  libmultipath/config.c                        |   4 +-
>  libmultipath/config.h                        |  14 +-
>  libmultipath/dict.c                          |  16 +-
>  libmultipath/dict.h                          |   2 -
>  libmultipath/foreign/Makefile                |   6 +-
>  libmultipath/libmultipath.version            |  41 ---
>  libmultipath/prioritizers/Makefile           |   8 +-
>  libmultipath/prioritizers/alua_rtpg.c        |   2 +-
>  libmultipath/prkey.c                         |  49 +++-
>  libmultipath/prkey.h                         |   3 +
>  mpathpersist/Makefile                        |   4 +-
>  multipath/Makefile                           |   6 +-
>  multipathd/Makefile                          |  43 ++-
>  multipathd/cli.c                             | 128 +--------
>  multipathd/cli.h                             |   5 +-
>  multipathd/main.c                            |  15 +-
>  multipathd/multipathc.c                      | 271 +++++++++++++++++++
>  multipathd/uxclnt.c                          | 108 +-------
>  tests/Makefile                               |  12 +-
>  53 files changed, 693 insertions(+), 395 deletions(-)
>  create mode 100644 libmpathutil/Makefile
>  rename {libmultipath => libmpathutil}/debug.c (100%)
>  rename {libmultipath => libmpathutil}/debug.h (100%)
>  create mode 100644 libmpathutil/globals.c
>  create mode 100644 libmpathutil/globals.h
>  create mode 100644 libmpathutil/libmpathutil.version
>  rename {libmultipath => libmpathutil}/log.c (100%)
>  rename {libmultipath => libmpathutil}/log.h (100%)
>  rename {libmultipath => libmpathutil}/log_pthread.c (100%)
>  rename {libmultipath => libmpathutil}/log_pthread.h (100%)
>  rename {libmultipath => libmpathutil}/parser.c (100%)
>  rename {libmultipath => libmpathutil}/parser.h (99%)
>  rename {libmultipath => libmpathutil}/strbuf.c (100%)
>  rename {libmultipath => libmpathutil}/strbuf.h (100%)
>  rename {libmultipath => libmpathutil}/time-util.c (100%)
>  rename {libmultipath => libmpathutil}/time-util.h (100%)
>  rename {libmultipath => libmpathutil}/util.c (92%)
>  rename {libmultipath => libmpathutil}/util.h (96%)
>  rename {libmultipath => libmpathutil}/uxsock.c (100%)
>  rename {libmultipath => libmpathutil}/uxsock.h (100%)
>  rename {libmultipath => libmpathutil}/vector.c (100%)
>  rename {libmultipath => libmpathutil}/vector.h (100%)
>  create mode 100644 multipathd/multipathc.c
> 
> -- 
> 2.37.1