[dm-devel] [PATCH] multipath-tools: tests: fix hwtable test

Benjamin Marzinski bmarzins at redhat.com
Thu Jun 9 15:22:59 UTC 2022


On Thu, Jun 09, 2022 at 12:13:55PM +0200, mwilck at suse.com wrote:
> From: Martin Wilck <mwilck at suse.com>
> 
> After "libmultipath: hwtable: new defaults for NVMe", we need to fix
> the unit tests.
> 
> Signed-off-by: Martin Wilck <mwilck at suse.com>

Reviewed-by: Benjamin Marzinski <bmarzins at redhat.com>

> ---
>  tests/hwtable.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/hwtable.c b/tests/hwtable.c
> index e60e914..bfaf613 100644
> --- a/tests/hwtable.c
> +++ b/tests/hwtable.c
> @@ -573,7 +573,7 @@ static void test_internal_nvme(const struct hwt_state *hwt)
>  	assert_ptr_not_equal(mp, NULL);
>  	TEST_PROP(checker_name(&pp->checker), NONE);
>  	TEST_PROP(pp->uid_attribute, DEFAULT_NVME_UID_ATTRIBUTE);
> -	assert_int_equal(mp->pgpolicy, DEFAULT_PGPOLICY);
> +	assert_int_equal(mp->pgpolicy, GROUP_BY_PRIO);
>  	assert_int_equal(mp->no_path_retry, DEFAULT_NO_PATH_RETRY);
>  	assert_int_equal(mp->retain_hwhandler, RETAIN_HWHANDLER_OFF);
>  
> @@ -586,7 +586,7 @@ static void test_internal_nvme(const struct hwt_state *hwt)
>  	assert_ptr_not_equal(mp, NULL);
>  	TEST_PROP(checker_name(&pp->checker), NONE);
>  	TEST_PROP(pp->uid_attribute, "ID_WWN");
> -	assert_int_equal(mp->pgpolicy, MULTIBUS);
> +	assert_int_equal(mp->pgpolicy, GROUP_BY_PRIO);
>  	assert_int_equal(mp->no_path_retry, NO_PATH_RETRY_QUEUE);
>  	assert_int_equal(mp->retain_hwhandler, RETAIN_HWHANDLER_OFF);
>  }
> -- 
> 2.36.1


More information about the dm-devel mailing list