[dm-devel] [PATCH 4/9] multipath-tools: add NetApp E-Series NVMe to hardware table

[Martin Wilck]

Xose,

On Thu, 2022-06-09 at 18:36 +0200, Xose Vazquez Perez wrote:
> On 5/26/22 22:10, Schremmer, Steven wrote:
> 
> > Sorry for being slow to respond to this. NetApp publishes settings
> > for
> > multipath-tools for NVMe-attach E-Series for specific distribution
> > versions
> > that we have qualified. Anyone using these settings outside of
> > these
> > versions would NOT be in a valid system configuration for NetApp
> > support. Are
> > reasonable defaults in the hardware table really useful if they
> > cause a user
> > to follow a path that leads them to an unsupported system
> > configuration?
> 
> Do you(@NetApp crew) realize that the "NVME/.*" prod/vendor was added
> more than five years ago:
> https://github.com/opensvc/multipath-tools/commit/4dd25783e13909cba0c38ed8bfedf76dc5a38c7b#diff-eeab98c4bb0459858e2ad17c9aa77ea30ee7a900e16cddb5325b9984b1694021
> 
> Your argument doesn't make any sense.

IIUC NetApp's concern is not the generic entry, but the entries
mentioning E-Series or it's OEM products in NVMe configuration
explicitly. I also have some trouble understanding the concern, but
NetApp is in charge of these entries, so I believe we should respect
what they're saying.

With the late patches I submitted, the generic NVMe defaults would work
for the NetApp devices without those being explicitly mentioned. I hope
this is ok for everyone. Only the no_path_retry setting would get lost,
which is acceptable IMO because this is rather an admin setting than
product-specific.

Regards
Martin