[dm-devel] [PATCH -next v2 7/7] md: don't check 'mddev->pers' and 'pers->quiesce' from suspend_lo_store()
Yu Kuai
yukuai1 at huaweicloud.com
Fri Aug 25 03:09:56 UTC 2023
From: Yu Kuai <yukuai3 at huawei.com>
Now that mddev_suspend() doean't rely on 'mddev->pers' to be set, it's
safe to remove such checking.
This will also allow the array to be suspended even before the array
is ran.
Signed-off-by: Yu Kuai <yukuai3 at huawei.com>
---
drivers/md/md.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 558cc752eb00..470986943e74 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -5180,18 +5180,13 @@ suspend_lo_store(struct mddev *mddev, const char *buf, size_t len)
err = mddev_lock(mddev);
if (err)
return err;
- err = -EINVAL;
- if (mddev->pers == NULL ||
- mddev->pers->quiesce == NULL)
- goto unlock;
+
mddev_suspend(mddev);
mddev->suspend_lo = new;
mddev_resume(mddev);
- err = 0;
-unlock:
mddev_unlock(mddev);
- return err ?: len;
+ return len;
}
static struct md_sysfs_entry md_suspend_lo =
__ATTR(suspend_lo, S_IRUGO|S_IWUSR, suspend_lo_show, suspend_lo_store);
--
2.39.2
More information about the dm-devel
mailing list