[dm-devel] [PATCH v2 1/4] libmultipath: don't bother to recheck timeout

[Benjamin Marzinski]

This is almost always pointless work. c->timeout has already been set.
The only reason why this recheck existed was to deal with the
possibility that the sysfs value had changed.  It is unlikely that users
will update the sysfs value to change the multipath timeout while
multipathd is running. They can alway reload multipathd if they want
it changed, anyways.

Signed-off-by: Benjamin Marzinski <bmarzins at redhat.com>
---
 libmultipath/discovery.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/libmultipath/discovery.c b/libmultipath/discovery.c
index 5626d48d..c90c51a6 100644
--- a/libmultipath/discovery.c
+++ b/libmultipath/discovery.c
@@ -1965,9 +1965,6 @@ get_state (struct path * pp, struct config *conf, int daemon, int oldstate)
 		checker_set_async(c);
 	else
 		checker_set_sync(c);
-	if (!conf->checker_timeout &&
-	    sysfs_get_timeout(pp, &(c->timeout)) <= 0)
-		c->timeout = DEF_TIMEOUT;
 	state = checker_check(c, oldstate);
 	condlog(3, "%s: %s state = %s", pp->dev,
 		checker_name(c), checker_state_name(state));
-- 
2.17.2