[dm-devel] [PATCH] multipathd.service: remove "Also=multipathd.socket"

[Benjamin Marzinski]

On Sat, Mar 25, 2023 at 11:28:20PM +0100, mwilck at suse.com wrote:
> From: Martin Wilck <mwilck at suse.com>
> 
> This "Also=" directive is wrong. It was meant for enabling socket activation,
> but it actually does the opposite. "Also=multipathd.socket" means that
> enabling/disabling the service will enable/disable the socket, too. This is
> not what we want: socket activation means that we can enable the socket
> while the service is disabled and will be activated by the socket on demand.
> 
> See https://github.com/dracutdevs/dracut/pull/2290,
> https://github.com/opensvc/multipath-tools/issues/65
> 
> Fixes: ca985df ("multipathd: switch to socket activation for systemd")
> Signed-off-by: Martin Wilck <mwilck at suse.com>
Reviewed-by: Benjamin Marzinski <bmarzins at redhat.com>
> ---
>  multipathd/multipathd.service | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/multipathd/multipathd.service b/multipathd/multipathd.service
> index aec62db..5a9cde1 100644
> --- a/multipathd/multipathd.service
> +++ b/multipathd/multipathd.service
> @@ -22,4 +22,3 @@ TasksMax=infinity
>  
>  [Install]
>  WantedBy=sysinit.target
> -Also=multipathd.socket
> -- 
> 2.39.2