[dm-devel] [PATCH v2 0/4] Make prio timeouts work like checkers
Martin Wilck
martin.wilck at suse.com
Fri Sep 1 16:40:23 UTC 2023
On Fri, 2023-09-01 at 18:16 +0200, Martin Wilck wrote:
> On Thu, 2023-08-31 at 16:57 -0500, Benjamin Marzinski wrote:
> > This patchset changes how prioritizers set their timeouts, to make
> > them
> > match how the checker functions work, and also cleans up some minor
> > timeout issues.
> >
> > This patchset has been entirely reworked based on suggestions from
> > Martin Wilck: Patch [1/4] no longer rechecks the timeout values at
> > all
> > in the checker loop. Patch [2/4] makes the checker_timeout a path
> > variable, following Martin's suggestion. Patch [3/4] roughly
> > corresponds
> > to patches 2, 3 & 4 of the previous patchset, except that it uses
> > the
> > path's checker_timeout variable to cleanup a number of function
> > calls,
> > and incidentally fixes the issues in detect_prio() and the
> > path_latency
> > prioritizer. Patch [4/4] is new. It makes the datacore checker
> > respect
> > the checker timeout as well, if no timeout is specified in the prio
> > args.
> >
> > Benjamin Marzinski (4):
> > libmultipath: don't bother to recheck timeout
> > libmultipath: make checker_timeout a path variable
> > libmultipath: make prioritizer timeouts work like checker
> > timeouts
> > libmultipath: standardize datacore prioritizer timeouts
> >
>
> For the series: Reviewed-by: Martin Wilck <mwilck at suse.com>
>
It turns out that the series breaks the hwtable unit test.
I'll see if I can fix it.
Martin
More information about the dm-devel
mailing list