<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv=Content-Type content="text/html; charset=us-ascii">
<meta name=Generator content="Microsoft Word 11 (filtered medium)">
<style>
<!--
/* Font Definitions */
@font-face
{font-family:"MS Sans Serif";
panose-1:0 0 0 0 0 0 0 0 0 0;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman";}
a:link, span.MsoHyperlink
{color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{color:purple;
text-decoration:underline;}
p
{mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman";}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"MS Sans Serif";
color:windowtext;
font-weight:normal;
font-style:normal;
text-decoration:none none;}
@page Section1
{size:8.5in 11.0in;
margin:1.0in 1.25in 1.0in 1.25in;}
div.Section1
{page:Section1;}
-->
</style>
</head>
<body lang=EN-US link=blue vlink=purple>
<div class=Section1>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>Using the patch you had sent, which uses
regcomp and regexec, policies are not effected on devices whose product ID is “OPEN<b><span
style='font-weight:bold'>-3</span></b>” or “OPEN<b><span
style='font-weight:bold'>-V</span></b>” or “OPEN<b><span
style='font-weight:bold'>-K</span></b>” if I have the following device
struct in /etc/multipath.conf.<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'><o:p> </o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'> device
{<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>
vendor
“HP “<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>
product
“OPEN
“<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'> path_checker
tur<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'> path_grouping_policy
multibus<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'> }<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'><o:p> </o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>My suggestion to changes are made in
strcmp_chomp is with out applying the patch you had sent.<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'><o:p> </o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>Thanks<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>-Murthy<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'><o:p> </o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'><o:p> </o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'><o:p> </o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>Date: Mon, 10 Oct 2005 14:23:22 +0200<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>From: Christophe Varoqui
<christophe.varoqui@free.fr><o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>Subject: [dm-devel] Re: DM configuration<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>To: dm-devel@redhat.com<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>Message-ID:
<20051010122322.GA23091@free.fr><o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>Content-Type: text/plain; charset=us-ascii<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'><o:p> </o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>On Mon, Oct 10, 2005 at 05:19:45PM +0530,
Murthy, Narasimha Doraswamy (STSD) wrote:<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>> Christophe,<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>> The one mentioned below will be
success for the regular expressions <o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>> that matches anywhere in the string.
Can we modify strcmp_chomp(...) <o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>> in <multipath-src>/libmultipath/utils.c
as below:<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>> <o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>> # diff util.c util.c.mod<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>> 29c29<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>>
< return(strcmp(s1,s2));<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>> ---<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>>
> return(strncmp(s1,s2,strlen(s1)));<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>> <o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>> so that both the partial string and
the complete string can be compared.<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>> <o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>> <o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>Hello,<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'><o:p> </o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>I fear I don't understand your mail : Isn't
the regexp solution enought ? Is it overkill ? Why modify strcmp_chomp(), as it
no longer is in the find_hwe() code path ?<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'><o:p> </o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>With the patch I posted you can specify
vendor/product ids like this :<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'><o:p> </o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'> device
{<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>
vendor
IET<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>
product
V.RTUAL.*K<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'> }<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'><o:p> </o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>Isn't that what you asked for ?<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'><o:p> </o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>Regards,<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="MS Sans Serif"><span style='font-size:
10.0pt;font-family:"MS Sans Serif"'>cvaroqui<o:p></o:p></span></font></p>
</div>
</body>
</html>