<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On May 16, 2012, at 7:50 PM, NeilBrown wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; ">On Tue, 15 May 2012 23:06:14 -0500 Jonathan Brassow <<a href="mailto:jbrassow@redhat.com">jbrassow@redhat.com</a>><br>wrote:<br><br><blockquote type="cite">Neil,<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">I've been seeing some really bad panics take place on dm-raid.c. I've<br></blockquote><blockquote type="cite">found that it is because the mddev->safemode_timer is firing after the<br></blockquote><blockquote type="cite">mddev structure has been freed. I've attached a patch to fix the<br></blockquote><blockquote type="cite">problem below, but I have some questions (outlined in the patch header).<br></blockquote><blockquote type="cite">I also have a debugging patch that prints something during each of the<br></blockquote><blockquote type="cite">suspend stages and when md_write_end resets the timer so that you can<br></blockquote><blockquote type="cite">see the problem in action - let me know if you want that patch also.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">brassow<br></blockquote><br>Hi Jon,<br>thanks for the patch. It looks simple and can clearly fix a problem<br>so at this point in the cycle I propose to submit it to Linus as-is, even<br>though I'm not convinced it is perfect, and you didn't give me a s-o-b line.<br>See more blow.<br></span></blockquote><div><br></div><div>Thanks Neil.</div><div><br></div><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><pet peeve>.<br>No Signed-off-by: line? why is that.<br><br>"Signed-off-by" *only* means "I certify that I have any necessary right to<br>submit this patch, and I agree to it being used in the way that all other<br>code in this project can be used" - only with more words. See the Developer's<br>Certificate of Origin 1.1<br><br>Refusing to add a Signed-off-by: because you don't think the code is "ready"<br>yet in some sense is just plain wrong. I never ever want to even see a patch<br>that doesn't have Signed-off-by, because I don't know if I've been given<br>permission to use it.<br><br>Certainly add an 'RFC-by' if you want to say something about the quality of<br>the patch, but don't for that reason exclude the signed-off-by<br></pet peeve><br></span></blockquote></div><br><div>"RFC-by" must be some overly clever thing I thought up or saw at one point. i can certainly break that habit. I had seen that possibly setting 'mddev->safemode = 2' might be a possible solution. I was also a bit confused if I should pull the 'del_timer_sync' from 'md_stop_writes'. This is why I put the RFC in there, but I see your meaning.</div><div><br></div><div>Thanks,</div><div> brassow</div></body></html>