<div dir="ltr">Commited,<div>Thanks.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Feb 2, 2016 at 10:37 PM, Mathieu Trudel-Lapierre <span dir="ltr"><<a href="mailto:mathieu.trudel-lapierre@canonical.com" target="_blank">mathieu.trudel-lapierre@canonical.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Le 2016-01-20 09:53, Christophe Varoqui a écrit :<br>
> Applied,<br>
> thanks.<br>
><br>
<br>
This patch apparently breaks the use of loopback-mounted files if you<br>
try to use them directly with kpartx -av.<br>
<br>
For instance:<br>
qemu-img create foo.img 20M<br>
sgdisk -n 1 foo.img<br>
kpartx -av foo.img<br>
<br>
<br>
Fails with the following error:<br>
device-mapper: reload ioctl on loop0p1 failed: No such device<br>
create/reload failed on loop0p1<br>
add map loop0p1 (0:0): 0 4192256 linear 0:0 2048<br>
<br>
<br>
This can be fixed by stat()'ing the loop device again after picking it:<br>
<br>
--- a/kpartx/kpartx.c<br>
+++ b/kpartx/kpartx.c<br>
@@ -322,6 +322,11 @@ main(int argc, char **argv){<br>
                        loopcreated = 1;<br>
                }<br>
                device = loopdev;<br>
+<br>
+               if (stat(device, &buf)) {<br>
+                       printf("failed to stat() %s\n", device);<br>
+                       exit (1);<br>
+               }<br>
        }<br>
<br>
        off = find_devname_offset(device);<br>
<span class="HOEnZb"><font color="#888888"><br>
<br>
<br>
<br>
--<br>
Mathieu Trudel-Lapierre <<a href="mailto:mathieu.trudel-lapierre@canonical.com">mathieu.trudel-lapierre@canonical.com</a>><br>
Freenode: cyphermox, Jabber: <a href="mailto:mathieu.tl@gmail.com">mathieu.tl@gmail.com</a><br>
4096R/65B58DA1 818A D123 0992 275B 23C2  CF89 C67B B4D6 65B5 8DA1<br>
<br>
</font></span><br>--<br>
dm-devel mailing list<br>
<a href="mailto:dm-devel@redhat.com">dm-devel@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/dm-devel" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/dm-devel</a><br></blockquote></div><br></div>