<font size=1>Hello, Ben</font>
<br>
<br><font size=1>Thanks for your review,</font>
<br><font size=1>This problem is found by our automatic testing,</font>
<br><font size=1>I will spend more time to correct other similar bugs in
the next patch。</font>
<br>
<br><font size=1>Cheers,</font>
<br><font size=1>Tang</font>
<br>
<br>
<br>
<br><font size=1 color=#5f5f5f face="sans-serif">发件人:
</font><font size=1 face="sans-serif">"Benjamin
Marzinski" <bmarzins@redhat.com></font>
<br><font size=1 color=#5f5f5f face="sans-serif">收件人:
</font><font size=1 face="sans-serif">tang.junhui@zte.com.cn,
</font>
<br><font size=1 color=#5f5f5f face="sans-serif">抄送:
</font><font size=1 face="sans-serif">dm-devel@redhat.com,
zhang.kai16@zte.com.cn, bart.vanassche@sandisk.com</font>
<br><font size=1 color=#5f5f5f face="sans-serif">日期:
</font><font size=1 face="sans-serif">2016/10/12
11:02</font>
<br><font size=1 color=#5f5f5f face="sans-serif">主题:
</font><font size=1 face="sans-serif">Re: [dm-devel]
[PATCH] multipathd: fail path when path check timeout</font>
<br><font size=1 color=#5f5f5f face="sans-serif">发件人:
</font><font size=1 face="sans-serif">dm-devel-bounces@redhat.com</font>
<br>
<hr noshade>
<br>
<br>
<br><tt><font size=2>On Tue, Oct 11, 2016 at 02:50:00PM +0800, tang.junhui@zte.com.cn
wrote:<br>
> Please have a review for this patch, any comment will
be highly<br>
> appreciated.<br>
<br>
This is clearly correct. I suspect that there will be other places where<br>
we need to also check for PATH_TIMEOUT, since it is basically the same<br>
as PATH_DOWN, except with a different state name. For instance, we<br>
only log error messages on repeated checks for (newstate == PATH_DOWN),<br>
and we should probably do that for PATH_TIMEOUT as well. There are<br>
probably more instances outside of check_path.<br>
<br>
-Ben<br>
<br>
> <br>
> ������: tang.junhui@zte.com.cn<br>
> �ռ���: christophe
varoqui <christophe.varoqui@free.fr>,<br>
> ����: dm-devel@redhat.com,
zhang.kai16@zte.com.cn, "tang.junhui"<br>
> <tang.junhui@zte.com.cn><br>
> ����: 2016/08/10
16:11<br>
> ����: [PATCH] multipathd:
fail path when path check timeout<br>
> <br>
> --------------------------------------------------------------------------<br>
> <br>
> From: "tang.junhui" <tang.junhui@zte.com.cn><br>
> <br>
> path should be failed when path status is PATH_TIMEOUT
after check,<br>
> otherwise, the valid number of paths in the map would
be increased when<br>
> the path status is PATH_UP after the next turn check,
which would cause<br>
> the valid number of paths exceeding the total number
of paths in the map.<br>
> <br>
> Signed-off-by: tang.junhui <tang.junhui@zte.com.cn><br>
> ---<br>
> multipathd/main.c | 2 +-<br>
> 1 file changed, 1 insertion(+), 1 deletion(-)<br>
> <br>
> diff --git a/multipathd/main.c b/multipathd/main.c<br>
> index f5e9a01..01f1e58 100644<br>
> --- a/multipathd/main.c<br>
> +++ b/multipathd/main.c<br>
> @@ -1585,7 +1585,7 @@ check_path (struct vectors * vecs,
struct path * pp,<br>
> int ticks)<br>
>
pp->checkint
= conf->checkint;<br>
>
put_multipath_config(conf);<br>
> <br>
> -
if (newstate
== PATH_DOWN || newstate<br>
> == PATH_SHAKY) {<br>
> +
if (newstate
== PATH_DOWN || newstate<br>
> == PATH_SHAKY || newstate == PATH_TIMEOUT) {<br>
>
/*<br>
>
* proactively fail<br>
> path in the DM<br>
>
*/<br>
> --<br>
> 2.8.1.windows.1<br>
<br>
--<br>
dm-devel mailing list<br>
dm-devel@redhat.com<br>
</font></tt><a href="https://www.redhat.com/mailman/listinfo/dm-devel"><tt><font size=2>https://www.redhat.com/mailman/listinfo/dm-devel</font></tt></a>
<br>