<div class="zcontentRow"> <p>If fast_io_fail_tmo isn't set, it will be use the DEFAULT_FAST_IO_FAIL in select_fast_io_fail.</p><p>So, multipath will not run the limited of dev_loss_tmo to 600.<br></p><p>And I think using MP_FAST_IO_FAIL_UNSET as the condition is meaningless after multipath</p><p>run <span style="line-height: 21px;">select_fast_io_fail even if it's not set.</span></p><p><br></p><div><div class="zhistoryRow" style="display:block"><div class="zhistoryDes" style="width: 100%; height: 28px; line-height: 28px; background-color: #E0E5E9; color: #1388FF; text-align: center;" language-data="HistoryOrgTxt">原始邮件</div><div id="zwriteHistoryContainer"><div class="control-group zhistoryPanel"><div class="zhistoryHeader" style="padding: 8px; background-color: #F5F6F8;"><div><strong language-data="HistorySenderTxt">发件人：</strong><span class="zreadUserName">BenjaminMarzinski</span></div><div><strong language-data="HistoryTOTxt">收件人：</strong><span class="zreadUserName" style="display: inline-block;">彭亮10137102;</span></div><div><strong language-data="HistoryCCTxt">抄送人：</strong><span class="zreadUserName" style="display: inline-block;">＜dm-devel@redhat.com＞</span><span class="zreadUserName" style="display: inline-block;">张凯10072500;</span></div><div><strong language-data="HistoryDateTxt">日 期 ：</strong><span class="">2016年11月29日 08:30</span></div><div><strong language-data="HistorySubjectTxt">主 题 ：</strong><span class="zreadTitle"><strong>Re: [dm-devel] [PATCH] libmultipath: ensure dev_loss_tmo will be update to MAX_DEV_LOSS_TMO if no_path_retry set to queue</strong></span></div></div><p class="zhistoryContent"><br></p><div>On Fri, Nov 25, 2016 at 02:36:04PM +0800, peng.liang5@zte.com.cn wrote:<br>＞ From: PengLiang ＜peng.liang5@zte.com.cn＞<br>＞ <br>＞ If no_path_retry set to queue, we should make sure dev_loss_tmo update to MAX_DEV_LOSS_TMO.<br>＞ But, it will be limit to 600 if fast_io_fail_tmo set to off or 0 meanwhile.<br><br>Doesn't the system still limit dev_loss_tmo to 600 if fast_io_fail_tmo isn't set. Multipath<br>was using this limit, since the underlying system uses it.<br><br>-Ben<br><br>＞ <br>＞ Signed-off-by: PengLiang ＜peng.liang5@zte.com.cn＞<br>＞ ---<br>＞  libmultipath/discovery.c | 3 ++-<br>＞  1 file changed, 2 insertions(+), 1 deletion(-)<br>＞ <br>＞ diff --git a/libmultipath/discovery.c b/libmultipath/discovery.c<br>＞ index aaa915c..05b0842 100644<br>＞ --- a/libmultipath/discovery.c<br>＞ +++ b/libmultipath/discovery.c<br>＞ @@ -608,7 +608,8 @@ sysfs_set_rport_tmo(struct multipath *mpp, struct path *pp)<br>＞                  goto out;<br>＞              }<br>＞          }<br>＞ -    } else if (mpp-＞dev_loss ＞ DEFAULT_DEV_LOSS_TMO) {<br>＞ +    } else if (mpp-＞dev_loss ＞ DEFAULT_DEV_LOSS_TMO &&<br>＞ +        mpp-＞no_path_retry != NO_PATH_RETRY_QUEUE) {<br>＞          condlog(3, "%s: limiting dev_loss_tmo to %d, since "<br>＞              "fast_io_fail is not set",<br>＞              rport_id, DEFAULT_DEV_LOSS_TMO);<br>＞ -- <br>＞ 2.8.1.windows.1<br><br>--<br>dm-devel mailing list<br>dm-devel@redhat.com<br>https://www.redhat.com/mailman/listinfo/dm-devel</div><p><br></p></div></div></div></div><p><br></p> </div>