<div dir="auto">Hi I am very new to this and am trying to learn because I'm very interested in this. Is there anyway someone would help someone like me. Thank you</div> <div class="gmail_quote"><div dir="ltr">On Wed, Sep 12, 2018, 12:01 PM <<a href="mailto:dm-devel-request@redhat.com">dm-devel-request@redhat.com</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Send dm-devel mailing list submissions to <a href="mailto:dm-devel@redhat.com" target="_blank" rel="noreferrer">dm-devel@redhat.com</a> To subscribe or unsubscribe via the World Wide Web, visit <a href="https://www.redhat.com/mailman/listinfo/dm-devel" rel="noreferrer noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/dm-devel</a> or, via email, send a message with subject or body 'help' to <a href="mailto:dm-devel-request@redhat.com" target="_blank" rel="noreferrer">dm-devel-request@redhat.com</a> You can reach the person managing the list at <a href="mailto:dm-devel-owner@redhat.com" target="_blank" rel="noreferrer">dm-devel-owner@redhat.com</a> When replying, please edit your Subject line so it is more specific than "Re: Contents of dm-devel digest..." Today's Topics: 1. Re: [PATCH] libmultipath: Increase SERIAL_SIZE to 256 bytes (Martin Wilck) ---------------------------------------------------------------------- Message: 1 Date: Wed, 12 Sep 2018 15:36:02 +0200 From: Martin Wilck <<a href="mailto:mwilck@suse.com" target="_blank" rel="noreferrer">mwilck@suse.com</a>> To: KyleMahlkuch <<a href="mailto:kmahlkuc@linux.vnet.ibm.com" target="_blank" rel="noreferrer">kmahlkuc@linux.vnet.ibm.com</a>>, <a href="mailto:dm-devel@redhat.com" target="_blank" rel="noreferrer">dm-devel@redhat.com</a> Subject: Re: [dm-devel] [PATCH] libmultipath: Increase SERIAL_SIZE to 256 bytes Message-ID: <<a href="mailto:f9c5e7fbc2136573a098b8aed475ce4eb7c0bf2a.camel@suse.com" target="_blank" rel="noreferrer">f9c5e7fbc2136573a098b8aed475ce4eb7c0bf2a.camel@suse.com</a>> Content-Type: text/plain; charset="UTF-8" On Tue, 2018-08-28 at 16:34 -0500, KyleMahlkuch wrote: > Certain IBM FlashSystem LUNs can return up to 85 bytes of serial > number in the Unit Serial Number VPD page, which is larger than > the current SERIAL_SIZE definition of 65 bytes. Since the max > size of this field does not appear to be defined in SPC, increasing > to 256 bytes should hopefully prevent us from hitting this > in future. > I'm not against it, but would 128 be enough, too? That's what we use for WWID. > This is an example of a serial number from a FlashSystem: > Unit serial number VPD page: > Unit serial number: > 3321360050764008101AB300000000000012204214503IBMfcp $ echo 3321360050764008101AB300000000000012204214503IBMfcp | wc -c 52 It looks as if 65 bytes would be sufficient for _this_ serial number. Is there excessive space padding at the end, maybe? Run sg_vpd -p sn -r $DEV | hexdump -C > > Before this patch multipath returns the error: > Jul 17 11:24:58 | vpd pg80 overflow, 85/65 bytes required > > After the patch is applied the error no longer occur. > > Signed-off-by: Kyle Mahlkuch <<a href="mailto:kmahlkuc@linux.vnet.ibm.com" target="_blank" rel="noreferrer">kmahlkuc@linux.vnet.ibm.com</a>> > --- > libmultipath/structs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, Martin -- Dr. Martin Wilck <<a href="mailto:mwilck@suse.com" target="_blank" rel="noreferrer">mwilck@suse.com</a>>, Tel. +49 (0)911 74053 2107 SUSE Linux GmbH, GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg) ------------------------------ -- dm-devel mailing list <a href="mailto:dm-devel@redhat.com" target="_blank" rel="noreferrer">dm-devel@redhat.com</a> <a href="https://www.redhat.com/mailman/listinfo/dm-devel" rel="noreferrer noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/dm-devel</a> End of dm-devel Digest, Vol 175, Issue 9 **************************************** </blockquote></div>