[edk2-devel] [Patch 0/3] BaseTools/PatchCheck: Fix false positives

[Liming Gao]

Mike:
  For this patch set, I am OK for those changes. Reviewed-by: Liming Gao <liming.gao at intel.com>

  But, I see there are some discussion on patch 3. After we make the conclusion, you can push it. 
  
Thanks
Liming
>-----Original Message-----
>From: Kinney, Michael D
>Sent: Friday, August 02, 2019 8:13 AM
>To: devel at edk2.groups.io
>Cc: Feng, Bob C <bob.c.feng at intel.com>; Gao, Liming
><liming.gao at intel.com>; Justen, Jordan L <jordan.l.justen at intel.com>
>Subject: [Patch 0/3] BaseTools/PatchCheck: Fix false positives
>
>https://bugzilla.tianocore.org/show_bug.cgi?id=2044
>
>* Add '--no-textconv' to 'git show' command to disable binary->text
>conversion.
>* Ignore blank lines in patch
>* Ignore lines with 'copy from ' and 'copy to ' prefixes
>
>Cc: Bob Feng <bob.c.feng at intel.com>
>Cc: Liming Gao <liming.gao at intel.com>
>Cc: Jordan Justen <jordan.l.justen at intel.com>
>Signed-off-by: Michael D Kinney <michael.d.kinney at intel.com>
>
>Michael D Kinney (3):
>  BaseTools/PatchCheck: Ignore blank lines in diff
>  BaseTools/PatchCheck: Add copy from/to keywords
>  BaseTools/PatchCheck: Disable text conversion in 'git show'
>
> BaseTools/Scripts/PatchCheck.py | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
>--
>2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#45000): https://edk2.groups.io/g/devel/message/45000
Mute This Topic: https://groups.io/mt/32685491/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-