[edk2-devel] [PATCH 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in INF file
Nate DeSimone
nathaniel.l.desimone at intel.com
Thu Aug 8 20:47:03 UTC 2019
Agreed with Chasel and Star. Once copyright is extended:
Reviewed-by: Nate DeSimone <nathaniel.l.desimone at intel.com>
-----Original Message-----
From: Zeng, Star
Sent: Thursday, August 8, 2019 7:56 AM
To: Chiu, Chasel <chasel.chiu at intel.com>; Zhang, Shenglei <shenglei.zhang at intel.com>; devel at edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone at intel.com>; Zeng, Star <star.zeng at intel.com>
Subject: RE: [PATCH 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in INF file
Same with Chasel. Reviewed-by: Star Zeng <star.zeng at intel.com>.
> -----Original Message-----
> From: Chiu, Chasel
> Sent: Thursday, August 8, 2019 2:59 PM
> To: Zhang, Shenglei <shenglei.zhang at intel.com>; devel at edk2.groups.io
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone at intel.com>; Zeng, Star
> <star.zeng at intel.com>
> Subject: RE: [PATCH 3/3] IntelFsp2Pkg/FspSecCore: Add missing header
> file in INF file
>
>
> Please extend copyright to 2019 of this file.
> With above change Reviewed-by: Chasel Chiu <chasel.chiu at intel.com>
>
>
> > -----Original Message-----
> > From: Zhang, Shenglei
> > Sent: Thursday, August 8, 2019 2:25 PM
> > To: devel at edk2.groups.io
> > Cc: Chiu, Chasel <chasel.chiu at intel.com>; Desimone, Nathaniel L
> > <nathaniel.l.desimone at intel.com>; Zeng, Star <star.zeng at intel.com>
> > Subject: [PATCH 3/3] IntelFsp2Pkg/FspSecCore: Add missing header
> > file in INF file
> >
> > SecFsp.h is used but missing inf file, which will cause generating
> > warning message.
> >
> > Cc: Chasel Chiu <chasel.chiu at intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone at intel.com>
> > Cc: Star Zeng <star.zeng at intel.com>
> > Signed-off-by: Shenglei Zhang <shenglei.zhang at intel.com>
> > ---
> > IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> > b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> > index 3de09b5b4921..86d3d31d3269 100644
> > --- a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> > +++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> > @@ -22,6 +22,7 @@ [Defines]
> >
> > [Sources]
> > SecFspApiChk.c
> > + SecFsp.h
> >
> > [Sources.IA32]
> > Ia32/Stack.nasm
> > --
> > 2.18.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#45230): https://edk2.groups.io/g/devel/message/45230
Mute This Topic: https://groups.io/mt/32796058/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list