[edk2-devel] [Patch] Vlv2TbltDevicePkg/VlvPlatformInitDxe: Avoid memset instrinsic

[Sun, Zailiang]

Reviewed-by: Zailiang Sun <Zailiang.sun at intel.com>

> -----Original Message-----
> From: Kinney, Michael D
> Sent: Saturday, August 10, 2019 5:24 AM
> To: devel at edk2.groups.io
> Cc: Sun, Zailiang <zailiang.sun at intel.com>; Gary Lin <glin at suse.com>
> Subject: [Patch] Vlv2TbltDevicePkg/VlvPlatformInitDxe: Avoid memset instrinsic
> 
> VS2017 builds for X64 are failing due to the use of the
> memset intrinsic.  The local variable GopVersion is an
> array that is initialied in the declaration.  Update to
> use ZeroMem() to intialize GopVersion.
> 
> Cc: Zailiang Sun <zailiang.sun at intel.com>
> Cc: Gary Lin <glin at suse.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney at intel.com>
> ---
>  .../Intel/Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c   | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c
> b/Platform/Intel/Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c
> index fcd9e566ae..3815c8fa9c 100644
> --- a/Platform/Intel/Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c
> @@ -493,9 +493,10 @@ SetGOPVersionCallback (
>    IN VOID      *Context
>    )
>  {
> -  CHAR16                GopVersion[16] = {0};
> +  CHAR16                GopVersion[16];
>    EFI_STATUS            Status;
> 
> +  ZeroMem (GopVersion, sizeof (GopVersion));
>    Status = GetGOPDriverVersion(GopVersion);
>    if(!EFI_ERROR(Status)) {
>      StrCpy((CHAR16*)&(mIgdOpRegion.OpRegion->Header.GOPV[0]),
> GopVersion);
> --
> 2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#45320): https://edk2.groups.io/g/devel/message/45320
Mute This Topic: https://groups.io/mt/32815340/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-