[edk2-devel] [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left

[Gao, Zhichao]

Reviewed-by: Zhichao Gao <zhichao.gao at intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Thursday, August 15, 2019 3:38 PM
> To: devel at edk2.groups.io
> Cc: Carsey, Jaben <jaben.carsey at intel.com>; Ni, Ray <ray.ni at intel.com>;
> Gao, Zhichao <zhichao.gao at intel.com>
> Subject: [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace shift
> logical left
> 
> Replace the operation to shift logical left with the function LShiftU64, which
> has the same functionality.
> The original code causes ShellPkg build failure with build target"-b NOOPT".
> 
> Cc: Jaben Carsey <jaben.carsey at intel.com>
> Cc: Ray Ni <ray.ni at intel.com>
> Cc: Zhichao Gao <zhichao.gao at intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang at intel.com>
> ---
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> index 2d6ff80e299e..2e6d99145beb 100644
> --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> @@ -290,7 +290,7 @@ DumpUint64 (
> 
>    Val = *(UINT32*)(Ptr + sizeof (UINT32));
> 
> -  Val <<= 32;
> +  LShiftU64(Val,32);
>    Val |= (UINT64)*(UINT32*)Ptr;
> 
>    Print (Format, Val);
> --
> 2.18.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#45784): https://edk2.groups.io/g/devel/message/45784
Mute This Topic: https://groups.io/mt/32884463/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-