[edk2-devel] [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Initialize local variables
Gao, Zhichao
zhichao.gao at intel.com
Fri Aug 16 04:07:51 UTC 2019
Reviewed-by: Zhichao Gao <zhichao.gao at intel.com>
Thanks,
Zhichao
> -----Original Message-----
> From: devel at edk2.groups.io [mailto:devel at edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Thursday, August 15, 2019 1:42 PM
> To: devel at edk2.groups.io
> Cc: Carsey, Jaben <jaben.carsey at intel.com>; Ni, Ray <ray.ni at intel.com>;
> Gao, Zhichao <zhichao.gao at intel.com>
> Subject: [edk2-devel] [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib:
> Initialize local variables
>
> At latest edk2 version, there is build failure when building ShellPkg with
> VS2012x86, which results from uninitialized local variables.
>
> Cc: Jaben Carsey <jaben.carsey at intel.com>
> Cc: Ray Ni <ray.ni at intel.com>
> Cc: Zhichao Gao <zhichao.gao at intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang at intel.com>
> ---
> .../Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 8 ++++++++
> .../Library/UefiShellAcpiViewCommandLib/AcpiView.c | 10 ++++++++++
> 2 files changed, 18 insertions(+)
>
> diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> index 2d6ff80e299e..94bafa22ef4c 100644
> --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> @@ -121,6 +121,10 @@ VerifyChecksum (
> UINT8 Checksum;
> UINTN OriginalAttribute;
>
> + //
> + // set local variables to suppress incorrect compiler/analyzer
> + warnings // OriginalAttribute = 0;
> ByteCount = 0;
> Checksum = 0;
>
> @@ -472,6 +476,10 @@ ParseAcpi (
> BOOLEAN HighLight;
> UINTN OriginalAttribute;
>
> + //
> + // set local variables to suppress incorrect compiler/analyzer
> + warnings // OriginalAttribute = 0;
> Offset = 0;
>
> // Increment the Indent
> diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
> index 9feb2df2078f..de0851dd5fba 100644
> --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
> +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
> @@ -211,6 +211,10 @@ ProcessTableReportOptions (
> BOOLEAN Log;
> BOOLEAN HighLight;
>
> + //
> + // set local variables to suppress incorrect compiler/analyzer
> + warnings // OriginalAttribute = 0;
> SignaturePtr = (UINT8*)(UINTN)&Signature;
> Log = FALSE;
> HighLight = GetColourHighlighting (); @@ -347,6 +351,12 @@ AcpiView (
> PARSE_ACPI_TABLE_PROC RsdpParserProc;
> BOOLEAN Trace;
>
> + //
> + // set local variables to suppress incorrect compiler/analyzer
> + warnings // EfiConfigurationTable = NULL; OriginalAttribute = 0;
> +
> // Search the table for an entry that matches the ACPI Table Guid
> FoundAcpiTable = FALSE;
> for (Index = 0; Index < SystemTable->NumberOfTableEntries; Index++) {
> --
> 2.18.0.windows.1
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#45785): https://edk2.groups.io/g/devel/message/45785
Mute This Topic: https://groups.io/mt/32883914/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list