[edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling.

[Liming Gao]

OK. So, you can't use git send-email to send this patch. Another way is to fork edk2 and create the branch to include this change.
Then, send the mail to let people review this patch in your branch.

And, for this patch, can you submit BZ https://bugzilla.tianocore.org/ first?
Then, update its commit message format based on this wiki.
https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format

Thanks
Liming
From: Jayanth.Raghuram at dell.com [mailto:Jayanth.Raghuram at dell.com]
Sent: Wednesday, August 28, 2019 2:30 AM
To: Gao, Liming <liming.gao at intel.com>; devel at edk2.groups.io
Cc: Wei.G.Liu at dell.com
Subject: RE: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling.

Hi Liming,

I sent the review request based on the description in the links that you mentioned below.
I sent it in an Dell Email since I cannot use GIT SMTP to send email out from our servers.
Please let me know what is wrong and I can help rectify that.

Regards
Jayanth Raghuram
DellEMC | Server Platform BIOS
office + 1 512 723 1470

From: Gao, Liming <liming.gao at intel.com<mailto:liming.gao at intel.com>>
Sent: Monday, August 26, 2019 8:57 PM
To: devel at edk2.groups.io<mailto:devel at edk2.groups.io>; Raghuram, Jayanth
Cc: Liu, Wei G
Subject: RE: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling.


[EXTERNAL EMAIL]
Can you follow this process to send this patch again?
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process

And, the commit message format is
https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format

Thanks
Liming
From: devel at edk2.groups.io<mailto:devel at edk2.groups.io> [mailto:devel at edk2.groups.io] On Behalf Of Jayanth.Raghuram at dell.com<mailto:Jayanth.Raghuram at dell.com>
Sent: Tuesday, August 27, 2019 3:55 AM
To: devel at edk2.groups.io<mailto:devel at edk2.groups.io>
Cc: Wei.G.Liu at dell.com<mailto:Wei.G.Liu at dell.com>
Subject: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling.

Subject: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling.
Added checks for return parameters of LocateHandleBuffer & GetSupportedTypes
function calls in InternalHstiFindAip to improve error handling. An issue was
observed on Dell Poweredge R740, where the Dell PERC H740P controller UEFI
driver returned InfoTypesBuffer = NULL, InfoTypesBufferCount = 0 and caused
an FreePool assert.

Signed-off-by: Jayanth Raghuram <Jayanth.Raghuram at Dell.com<mailto:Jayanth.Raghuram at Dell.com>>
Cc: Wei G Liu <Wei_G_Liu at Dell.com<mailto:Wei_G_Liu at Dell.com>>

Attached: 0001-MdePkg-DxeHstiLib-Added-checks-to-improve-error-hand.patch

Regards
Jayanth Raghuram
DellEMC | Server Platform BIOS
office + 1 512 723 1470



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#46530): https://edk2.groups.io/g/devel/message/46530
Mute This Topic: https://groups.io/mt/33041050/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20190828/7eeab898/attachment.htm>