[edk2-devel] [PATCH 10/79] IntelFsp2WrapperPkg: Fix various typos

Wed Dec 4 01:22:46 UTC 2019

Philippe, thanks for helping on this.

Just minor feedbacks - many files having old copyright years that I replied below inline, please help to correct them.
With copyright updated, Reviewed-by: Chasel Chiu <chasel.chiu at intel.com>

> -----Original Message-----
> From: Philippe Mathieu-Daude <philmd at redhat.com>
> Sent: Wednesday, December 4, 2019 12:15 AM
> To: devel at edk2.groups.io
> Cc: Antoine Coeur <coeur at gmx.fr>; Chiu, Chasel <chasel.chiu at intel.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone at intel.com>; Zeng, Star
> <star.zeng at intel.com>; Philippe Mathieu-Daude <philmd at redhat.com>
> Subject: [PATCH 10/79] IntelFsp2WrapperPkg: Fix various typos
> 
> From: Antoine Coeur <coeur at gmx.fr>
> 
> Fix various typos in comments and documentation.
> 
> Cc: Chasel Chiu <chasel.chiu at intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone at intel.com>
> Cc: Star Zeng <star.zeng at intel.com>
> Reviewed-by: Philippe Mathieu-Daude <philmd at redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd at redhat.com>
> ---
>  IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
> | 2 +-
>  IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
> | 4 ++--
>  IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> | 2 +-
> 
> IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapp
> erPlatformLibSample.c    | 4 ++--
> 
> IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWrap
> perHobProcessLibSample.c | 4 ++--
> 
> IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.nas
> m                        | 6 +++---
> 
> IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/Sec
> Entry.nasm             | 2 +-
> 
> IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/Sta
> ck.nasm                | 2 +-
>  8 files changed, 13 insertions(+), 13 deletions(-)
> 
> diff --git a/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
> b/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
> index e39054c30d3b..11a3faaad87a 100644
> --- a/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
> +++ b/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h

Copyright for this file should be "2014 - 2019"

> @@ -40,7 +40,7 @@ CallFspNotifyPhase (
>  /**
>    Call FSP API - FspMemoryInit.
> 
> -  @param[in]  FspmUpdDataPtr          Pointer to the FSPM_UPD data
> sructure.
> +  @param[in]  FspmUpdDataPtr          Pointer to the FSPM_UPD data
> structure.
>    @param[out] HobListPtr              Pointer to receive the address
> of the HOB list.
> 
>    @return EFI status returned by FspMemoryInit API.
> diff --git a/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
> b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
> index b90f0eb78302..2aa14c92fd63 100644
> --- a/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
> +++ b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h

Copyright for this file should be "2014 - 2019"

> @@ -12,7 +12,7 @@
>  /**
>    This function overrides the default configurations in the FSP-M UPD data
> region.
> 
> -  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data
> strcture.
> +  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data
> structure.
> 
>  **/
>  VOID
> @@ -24,7 +24,7 @@ UpdateFspmUpdData (
>  /**
>    This function overrides the default configurations in the FSP-S UPD data
> region.
> 
> -  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data
> strcture.
> +  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data
> structure.
> 
>  **/
>  VOID
> diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> index 0f8cd69a0e6e..b20f0805a021 100644
> --- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> +++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> @@ -352,7 +352,7 @@ FspsWrapperInitApiMode (
>    EFI_BOOT_MODE        BootMode;
> 
>    //
> -  // Register MemoryDiscovered Nofity to run FspSiliconInit
> +  // Register MemoryDiscovered Notify to run FspSiliconInit
>    //
>    Status = PeiServicesNotifyPpi (&mPeiMemoryDiscoveredNotifyDesc);
>    ASSERT_EFI_ERROR (Status);
> diff --git
> a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWra
> pperPlatformLibSample.c
> b/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWra
> pperPlatformLibSample.c
> index def04b176659..dddf80b76c26 100644
> ---
> a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWra
> pperPlatformLibSample.c
> +++
> b/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWra
> pperPlatformLibSample.c

Copyright for this file should be "2014 - 2019"

> @@ -14,7 +14,7 @@
> 
>    @note At this point, memory is NOT ready, PeiServices are available to
> use.
> 
> -  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data
> strcture.
> +  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data
> structure.
> 
>  **/
>  VOID
> @@ -28,7 +28,7 @@ UpdateFspmUpdData (
>  /**
>    This function overrides the default configurations in the FSP-S UPD data
> region.
> 
> -  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data
> strcture.
> +  @param[in,out] FspUpdRgnPtr   A pointer to the UPD data region data
> structure.
> 
>  **/
>  VOID
> diff --git
> a/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWr
> apperHobProcessLibSample.c
> b/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWr
> apperHobProcessLibSample.c
> index 54cebe127c8f..48f4b0295a30 100644
> ---
> a/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWr
> apperHobProcessLibSample.c
> +++
> b/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWr
> apperHobProcessLibSample.c
> @@ -29,11 +29,11 @@
>  #define PEI_ADDITIONAL_MEMORY_SIZE    (16 * EFI_PAGE_SIZE)
> 
>  /**
> -  Get the mem size in memory type infromation table.
> +  Get the mem size in memory type information table.
> 
>    @param[in] PeiServices  PEI Services table.
> 
> -  @return the mem size in memory type infromation table.
> +  @return the mem size in memory type information table.
>  **/
>  UINT64
>  GetMemorySizeInMemoryTypeInformation (
> diff --git
> a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.n
> asm
> b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.n
> asm
> index 45c8f21255e3..db8e62ebc5a8 100644
> ---
> a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.n
> asm
> +++
> b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.n
> asm

Copyright for this file should be "2016 - 2019"

> @@ -43,7 +43,7 @@ ASM_PFX(AsmExecute32BitCode):
>      cli
> 
>      ;
> -    ; save orignal GDTR and CS
> +    ; save original GDTR and CS
>      ;
>      mov     rax, ds
>      push    rax
> @@ -190,7 +190,7 @@ ReloadCS:
>      pop     rdi
>      popfq
>      ;
> -    ; Switch to orignal GDT and CS. here rsp is pointer to the orignal GDT
> descriptor.
> +    ; Switch to original GDT and CS. here rsp is pointer to the original GDT
> descriptor.
>      ;
>      lgdt    [rsp]
>      ;
> @@ -198,7 +198,7 @@ ReloadCS:
>      ;
>      add     rsp, 0x10
>      ;
> -    ; switch to orignal CS and GDTR
> +    ; switch to original CS and GDTR
>      ;
>      pop     r9                 ; get  CS
>      shl     r9,  32            ; rcx[32..47] <- Cs
> diff --git
> a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/S
> ecEntry.nasm
> b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/S
> ecEntry.nasm
> index d8d0582cb4fa..9f190bb25b0f 100644
> ---
> a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/S
> ecEntry.nasm
> +++
> b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/S
> ecEntry.nasm

Copyright for this file should be "2016- 2019"

> @@ -207,7 +207,7 @@ TempRamInitDone:
>    cmp eax, 8000000Eh      ;Check if EFI_NOT_FOUND returned. Error
> code for Microcode Update not found.
>    je  CallSecFspInit      ;If microcode not found, don't hang, but
> continue.
> 
> -  cmp eax, 0              ;Check if EFI_SUCCESS retuned.
> +  cmp eax, 0              ;Check if EFI_SUCCESS returned.
>    jnz FspApiFailed
> 
>    ;   ECX: start of range
> diff --git
> a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/S
> tack.nasm
> b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/S
> tack.nasm
> index ba989bd4412b..d7394cf286c6 100644
> ---
> a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/S
> tack.nasm
> +++
> b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/S
> tack.nasm

Copyright for this file should be "2016 - 2019"

> @@ -5,7 +5,7 @@
>  ;
>  ; Abstract:
>  ;
> -;   Switch the stack from temporary memory to permenent memory.
> +;   Switch the stack from temporary memory to permanent memory.
>  ;
>  ;------------------------------------------------------------------------------
> 
> --
> 2.21.0

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51699): https://edk2.groups.io/g/devel/message/51699
Mute This Topic: https://groups.io/mt/65773146/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-