[edk2-devel] [PATCH] Maintainers.txt: Update reviewer email address

Tue Dec 10 09:10:50 UTC 2019

On 12/10/19 09:35, Rabeda, Maciej wrote:
> Ok, Jiaxin :)
>
> Mike, Laszlo, Liming,
>
> Do you know who I should contact in regards to maintainership role
> transition (edk2 write access etc.)?

Write access directly to the edk2 repo has been revoked from
maintainers.

Documentation updates are underway by Mike, to my understanding. Please
see the following threads:

- [edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master
  http://mid.mail-archive.com/E92EE9817A31E24EB0585FDF735412F5B9E173A1@ORSMSX113.amr.corp.intel.com
  https://edk2.groups.io/g/devel/message/50407

- [edk2-devel] [Patch wiki v2] EDK II CI: Update Phase 1 details and admin settings
  http://mid.mail-archive.com/20191202175630.12788-1-michael.d.kinney@intel.com
  https://edk2.groups.io/g/devel/message/51556

- [edk2-devel] [Patch wiki v2] EDK II Dev Process: Change push to GitHub pull request
  http://mid.mail-archive.com/20191202180131.876-1-michael.d.kinney@intel.com
  https://edk2.groups.io/g/devel/message/51557

For a brief (personal, informal) summary, I can offer (quoting an email
I sent earlier):

- prepare a local topic branch, on top of master, with the review tags
  in place, such that (per the earlier method) you'd ff-push that topic
  branch as the new edk2 master.

- instead of pushing it to edk2, push it to your personal edk2 repo on
  github.com

- log in to github.com, and initiate a pull request against edk2/master,
  from your personal topic branch

- as soon as the pull request has been filed, locate the "labels" box to
  the right, and apply the "push" label.

Once the CI tests complete, the branch will be merged (fast-forwarded).

The official description will be in the wiki, containing even
screenshots. See the third reference above, from Mike. For now, those
updates can be seen rendered in Mike's clone of the Wiki, namely at
<https://github.com/mdkinney/edk2/wiki/EDK-II-Development-Process>.

Thanks
Laszlo

> -----Original Message-----
> From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Wu, Jiaxin
> Sent: Tuesday, December 10, 2019 06:38
> To: Maciej Rabeda <maciej.rabeda at linux.intel.com>; devel at edk2.groups.io
> Cc: Fu, Siyuan <siyuan.fu at intel.com>
> Subject: Re: [edk2-devel] [PATCH] Maintainers.txt: Update reviewer email address
>
> Hi Maciej,
>
> I think now you can update you as one of NetworkPkg maintainers, if so, you can get the edk2 repo write privilege, which can facility your future contribution. I will still keep the maintainer role until next month. After that, both Siyuan and I will be reviewer, so, we can still help the technical review/support.
>
> If no objection, just do that:).
>
> Thanks,
> Jiaxin
>
>> -----Original Message-----
>> From: Maciej Rabeda <maciej.rabeda at linux.intel.com>
>> Sent: Saturday, December 7, 2019 12:29 AM
>> To: devel at edk2.groups.io
>> Cc: Wu, Jiaxin <jiaxin.wu at intel.com>; Fu, Siyuan <siyuan.fu at intel.com>
>> Subject: [PATCH] Maintainers.txt: Update reviewer email address
>>
>> Created new email account that will not append legal disclaimers to my
>> responses/patches.
>>
>> Cc: Jiaxin Wu <jiaxin.wu at intel.com>
>> Cc: Siyuan Fu <siyuan.fu at intel.com>
>> Signed-off-by: Maciej Rabeda <maciej.rabeda at linux.intel.com>
>> ---
>>  Maintainers.txt | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Maintainers.txt b/Maintainers.txt index
>> 180ad35d0976..246583204139 100644
>> --- a/Maintainers.txt
>> +++ b/Maintainers.txt
>> @@ -379,7 +379,7 @@ F: NetworkPkg/
>>  W: https://github.com/tianocore/tianocore.github.io/wiki/NetworkPkg
>>
>>  M: Jiaxin Wu <jiaxin.wu at intel.com>
>>
>>  R: Siyuan Fu <siyuan.fu at intel.com>
>>
>> -R: Maciej Rabeda <maciej.rabeda at intel.com>
>>
>> +R: Maciej Rabeda <maciej.rabeda at linux.intel.com>
>>
>>
>>
>>  OvmfPkg
>>
>>  F: OvmfPkg/
>>
>> --
>> 2.24.0.windows.2
>
>
> 
>
> --------------------------------------------------------------------
>
> Intel Technology Poland sp. z o.o.
> ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
>
> Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
> przegladanie lub rozpowszechnianie jest zabronione.
> This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
> others is strictly prohibited.
>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#52077): https://edk2.groups.io/g/devel/message/52077
Mute This Topic: https://groups.io/mt/67501831/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-