[edk2-devel] [PATCH] MdePkg/Spdm: fix Nonce structure error.

[Liming Gao]

That's good. Thanks!

>-----Original Message-----
>From: Yao, Jiewen
>Sent: Thursday, December 19, 2019 6:32 AM
>To: Gao, Liming <liming.gao at intel.com>; devel at edk2.groups.io
>Cc: Kinney, Michael D <michael.d.kinney at intel.com>
>Subject: RE: [PATCH] MdePkg/Spdm: fix Nonce structure error.
>
>No impact.
>Current code does not use Nonce.
>I just find the issue when I review the final 1.0 spec.
>
>Thank you
>Yao Jiewen
>
>> -----Original Message-----
>> From: Gao, Liming <liming.gao at intel.com>
>> Sent: Wednesday, December 18, 2019 10:32 PM
>> To: Yao, Jiewen <jiewen.yao at intel.com>; devel at edk2.groups.io
>> Cc: Kinney, Michael D <michael.d.kinney at intel.com>
>> Subject: RE: [PATCH] MdePkg/Spdm: fix Nonce structure error.
>>
>> Jiewen:
>>   The change is good. Have you found any impact in the existing code?
>>
>>   Reviewed-by: Liming Gao <liming.gao at intel.com>
>>
>> Thanks
>> Liming
>> > -----Original Message-----
>> > From: Yao, Jiewen <jiewen.yao at intel.com>
>> > Sent: Wednesday, December 18, 2019 11:00 AM
>> > To: devel at edk2.groups.io
>> > Cc: Kinney, Michael D <michael.d.kinney at intel.com>; Gao, Liming
>> <liming.gao at intel.com>
>> > Subject: [PATCH] MdePkg/Spdm: fix Nonce structure error.
>> >
>> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2427
>> >
>> > Align to SPDM 1.0.0 specification.
>> > Fix Nonce data structure error.
>> >
>> > Cc: Michael D Kinney <michael.d.kinney at intel.com>
>> > Cc: Liming Gao <liming.gao at intel.com>
>> > Signed-off-by: Jiewen Yao <jiewen.yao at intel.com>
>> > ---
>> >  MdePkg/Include/IndustryStandard/Spdm.h | 10 +++++-----
>> >  1 file changed, 5 insertions(+), 5 deletions(-)
>> >
>> > diff --git a/MdePkg/Include/IndustryStandard/Spdm.h
>> b/MdePkg/Include/IndustryStandard/Spdm.h
>> > index c05395fea7..38ec7748a7 100644
>> > --- a/MdePkg/Include/IndustryStandard/Spdm.h
>> > +++ b/MdePkg/Include/IndustryStandard/Spdm.h
>> > @@ -1,6 +1,6 @@
>> >  /** @file
>> >    Definitions of Security Protocol & Data Model Specification (SPDM)
>> > -  version 0.99a in Distributed Management Task Force (DMTF).
>> > +  version 1.0.0 in Distributed Management Task Force (DMTF).
>> >
>> >  Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
>> >  SPDX-License-Identifier: BSD-2-Clause-Patent
>> > @@ -215,7 +215,7 @@ typedef struct {
>> >  ///
>> >  typedef struct {
>> >    SPDM_MESSAGE_HEADER  Header;
>> > -  UINT32               Nonce;
>> > +  UINT8                Nonce[32];
>> >  } SPDM_CHALLENGE_REQUEST;
>> >
>> >  ///
>> > @@ -224,7 +224,7 @@ typedef struct {
>> >  typedef struct {
>> >    SPDM_MESSAGE_HEADER  Header;
>> >  //UINT8                CertChainHash[DigestSize];
>> > -//UINT32               Nonce;
>> > +//UINT8                Nonce[32];
>> >  //UINT8                MeasurementSummaryHash[DigestSize];
>> >  //UINT16               OpaqueLength;
>> >  //UINT8                OpaqueData[OpaqueLength];
>> > @@ -236,7 +236,7 @@ typedef struct {
>> >  ///
>> >  typedef struct {
>> >    SPDM_MESSAGE_HEADER  Header;
>> > -  UINT32               Nonce;
>> > +  UINT8                Nonce[32];
>> >  } SPDM_GET_MEASUREMENTS_REQUEST;
>> >
>> >  ///
>> > @@ -277,7 +277,7 @@ typedef struct {
>> >    UINT8                NumberOfBlocks;
>> >    UINT8                MeasurementRecordLength[3];
>> >  //UINT8                MeasurementRecord[MeasurementRecordLength];
>> > -//UINT32               Nonce;
>> > +//UINT8                Nonce[32];
>> >  //UINT16               OpaqueLength;
>> >  //UINT8                OpaqueData[OpaqueLength];
>> >  //UINT8                Signature[KeySize];
>> > --
>> > 2.19.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#52390): https://edk2.groups.io/g/devel/message/52390
Mute This Topic: https://groups.io/mt/68781647/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-