[edk2-devel] [Patch] GenBiosId: Fixed a regression bug introduced by 8b72f720d53e

[Liming Gao]

Reviewed-by: Liming Gao <liming.gao at intel.com>

> -----Original Message-----
> From: Feng, Bob C <bob.c.feng at intel.com>
> Sent: Friday, December 20, 2019 4:42 PM
> To: devel at edk2.groups.io
> Cc: Gao, Liming <liming.gao at intel.com>; Kilian Kegel <kilian_kegel at outlook.com>
> Subject: [Patch] GenBiosId: Fixed a regression bug introduced by 8b72f720d53e
> 
> 8b72f720d53e introduced a regression bug that make GenBiosId
> failed if -ot is passed to this tool.
> 
> This patch is going to fix it.
> 
> Cc: Liming Gao <liming.gao at intel.com>
> Cc: Kilian Kegel <kilian_kegel at outlook.com>
> Signed-off-by: Bob Feng <bob.c.feng at intel.com>
> ---
>  Platform/Intel/Tools/GenBiosId/GenBiosId.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Platform/Intel/Tools/GenBiosId/GenBiosId.py b/Platform/Intel/Tools/GenBiosId/GenBiosId.py
> index 8cecb1c76f..f823fdcad1 100644
> --- a/Platform/Intel/Tools/GenBiosId/GenBiosId.py
> +++ b/Platform/Intel/Tools/GenBiosId/GenBiosId.py
> @@ -107,11 +107,11 @@ def MyOptionParser():
>      return Options
> 
> 
>  # Check the Tool for missing variables
>  def CheckOptions(Options):
> -    if len(sys.argv) not in [5,6] and not (len(sys.argv) not in [7,8] and Options.OutputTextFile):
> +    if len(sys.argv) not in [5,6] and not (len(sys.argv) in [7,8] and Options.OutputTextFile):
>          EdkLogger("GenBiosId", OPTION_MISSING, ExtraData=_Usage)
>      elif not Options.InputFile or not Options.OutputFile:
>          EdkLogger("GenBiosId", OPTION_MISSING, ExtraData=_Usage)
>      InputFile = Options.InputFile
>      OutputFile = Options.OutputFile
> --
> 2.20.1.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#52479): https://edk2.groups.io/g/devel/message/52479
Mute This Topic: https://groups.io/mt/68846618/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-