[edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

[Ard Biesheuvel]

On Tue, 4 Jun 2019 at 15:40, Gao, Liming <liming.gao at intel.com> wrote:
>
> Ard:
>
> > -----Original Message-----
> > From: devel at edk2.groups.io [mailto:devel at edk2.groups.io] On Behalf Of Ard Biesheuvel
> > Sent: Tuesday, June 4, 2019 7:53 PM
> > To: edk2-devel-groups-io <devel at edk2.groups.io>; Ni, Ray <ray.ni at intel.com>; Leif Lindholm <leif.lindholm at linaro.org>; Gao, Liming
> > <liming.gao at intel.com>; Laszlo Ersek <lersek at redhat.com>; Kinney, Michael D <michael.d.kinney at intel.com>
> > Cc: Liu, Zhiguang <zhiguang.liu at intel.com>; Justen, Jordan L <jordan.l.justen at intel.com>; Andrew Fish <afish at apple.com>
> > Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed
> >
> > On Tue, 4 Jun 2019 at 10:50, Ni, Ray <ray.ni at intel.com> wrote:
> > >
> > > Zhiguang,
> > > I made a mistake here.
> > > I thought you changed the EmulatorPkg to not display the CPU speed
> > > but actually what you changed impacts all platforms.
> > > With this change, OVMF cannot show the CPU speed either.
> > >
> > > Can you please roll back this changes (if it was pushed in)?
> > >
> >
> > OK, this patch mentions EmulatorPkg in the commit log but actually
> > modifies MdeModulePkg, and it was pushed during the hard freeze.
> >
> > Seriously, how did this happen? I would expect everyone with commit
> > rights to the repository to be aware of the stable tag rules and
> > release cadence.
>
> This patch is like a bug fix.

How so? Why does it qualify as a bug fix that can be applied during
the hard freeze period?

> But, this patch changes the code in MdeModulePkg.
> It requires MdeModulePkg package maintainer and reviewer to review it.
> And, it impacts the different platforms. So, I also prefer to roll back this change.
>

Agreed.


> >
> > 
>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41862): https://edk2.groups.io/g/devel/message/41862
Mute This Topic: https://groups.io/mt/31907735/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-