[edk2-devel] [PATCH] CryptoPkg/OpensslLib: fix build break caused by missing library

[Liming Gao]

Reviewed-by: Liming Gao <liming.gao at intel.com>

> -----Original Message-----
> From: Wang, Jian J
> Sent: Thursday, June 6, 2019 10:57 AM
> To: devel at edk2.groups.io
> Cc: Gao, Liming <liming.gao at intel.com>; Bi, Dandan <dandan.bi at intel.com>
> Subject: [PATCH] CryptoPkg/OpensslLib: fix build break caused by missing library
> 
> CryptoPkg\Library\Include\CrtLibSupport.h maps strxxxx interfaces to
> edk2 PrintLib interfaces but related module inf file don't claim the
> use of it. This will cause unresolved symbol issue with VS2017 build
> which has enabled strict symbol check. This patch resolves the problem
> by adding PrintLib to inf files.
> 
> Cc: Liming Gao <liming.gao at intel.com>
> Cc: Dandan Bi <dandan.bi at intel.com>
> Signed-off-by: Jian J Wang <jian.j.wang at intel.com>
> ---
>  CryptoPkg/Library/OpensslLib/OpensslLib.inf       | 1 +
>  CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> index 5a2424fc16..5f36edeeef 100644
> --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> @@ -562,6 +562,7 @@
>    BaseLib
>    DebugLib
>    TimerLib
> +  PrintLib
> 
>  [LibraryClasses.ARM]
>    ArmSoftFloatLib
> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> index 588da4c040..de05cac931 100644
> --- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> +++ b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> @@ -518,6 +518,7 @@
>    BaseLib
>    DebugLib
>    TimerLib
> +  PrintLib
> 
>  [LibraryClasses.ARM]
>    ArmSoftFloatLib
> --
> 2.17.1.windows.2


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41977): https://edk2.groups.io/g/devel/message/41977
Mute This Topic: https://groups.io/mt/31946387/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-