[edk2-devel] [PATCH 1/2] Platform/Intel: Update Kabylake build steps.

[Nate DeSimone]

It's good that we have the Python 2.x dependency documented for KabyLakeOpenBoardPkg now, but we really need to migrate it to Python 3.x since security updates for Python 2.x will be ending soon.

Reviewed-by: Nate DeSimone <nathaniel.l.desimone at intel.com>

-----Original Message-----
From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Chiu, Chasel
Sent: Tuesday, June 11, 2019 8:29 PM
To: devel at edk2.groups.io
Cc: Kubacki, Michael A <michael.a.kubacki at intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone at intel.com>; Gao, Liming <liming.gao at intel.com>
Subject: [edk2-devel] [PATCH 1/2] Platform/Intel: Update Kabylake build steps.

https://bugzilla.tianocore.org/show_bug.cgi?id=1905

KabylakeOpenBoardPkg no longer supported batch file build, it only supports build_bios.py.
ReadMe.md should be updated and batch files should be removed.

Test: both API mode and Dispatch mode can build
      successfully by build_bios.py

Cc: Michael Kubacki <michael.a.kubacki at intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone at intel.com>
Cc: Liming Gao <liming.gao at intel.com>
Signed-off-by: Chasel Chiu <chasel.chiu at intel.com>
---
 Platform/Intel/Readme.md | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/Platform/Intel/Readme.md b/Platform/Intel/Readme.md index 443fb409b3..cc0151066e 100644
--- a/Platform/Intel/Readme.md
+++ b/Platform/Intel/Readme.md
@@ -101,7 +101,7 @@ return back to the minimum platform caller.
   * ``git clone https://github.com/tianocore/edk2-non-osi.git -b devel-MinPlatform``
 
 * FSP repository
-  * ``git clone https://github.com/IntelFsp/FSP.git -b Kabylake``
+  * ``git clone https://github.com/IntelFsp/FSP.git``
 
 ### Build
 
@@ -132,7 +132,8 @@ return back to the minimum platform caller.
   | --capsule             | capsule build enabled               |
   | --silent              | silent build enabled                |
   | --performance         | performance build enabled           |
-  | --fsp                 | fsp build enabled                   |
+  | --fsp                 | fsp wrapper build enabled           |
+  | --fspapi              | API mode fsp wrapper build enabled  |
   |                                                             |
 
 * For more information on build options @@ -140,6 +141,8 @@ return back to the minimum platform caller.
 
 * Note
   * Python 2.7.16 and Python 3.7.3 compatible
+  * Some dependency Python scripts might only support 2.x or 3.x, if that happened use
+    "py -2" or "py -3" to launch build_bios.py
   * This python build script has been tested on Windows 10 and Ubuntu 16.04.5 LTS
   * See [cross-platform limitations](#Known-limitations)
 
@@ -186,12 +189,7 @@ return back to the minimum platform caller.
   </pre>
 
 **Building with the batch scripts**
-For KabylakeOpenBoardPkg
-1. Open command window, go to the workspace directory, e.g. c:\Kabylake.
-2. Type "cd edk2-platforms\Platform\Intel\KabylakeOpenBoardPkg\KabylakeRvp3".
-3. Type "GitEdk2MinKabylake.bat" to setup GIT environment.
-4. Type "prep" and make prebuild finish for debug build, "prep r" for release build.
-5. Type "bld" to build Kaby Lake reference platform UEFI firmware image.
+KabylakeOpenBoardPkg does not support batch scripts, please use build_bios.py.
 
 For PurleyOpenBoardPkg
 1. Open command window, go to the workspace directory, e.g. c:\Purley.
--
2.13.3.windows.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42250): https://edk2.groups.io/g/devel/message/42250
Mute This Topic: https://groups.io/mt/32037607/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-