[edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for every PPB device in the system

[Wu, Hao A]

> -----Original Message-----
> From: devel at edk2.groups.io [mailto:devel at edk2.groups.io] On Behalf Of Ni,
> Ray
> Sent: Monday, June 17, 2019 5:49 PM
> To: Javeed, Ashraf; devel at edk2.groups.io
> Cc: Wang, Jian J
> Subject: Re: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for
> every PPB device in the system
> 
> Reviewed-by: Ray Ni <ray.ni at intel.com>

Hello all,

I did not see the origin patch being sent to the mailing list.
Maybe Ashraf has not subscribed the mailing list?

Best Regards,
Hao Wu

> 
> > -----Original Message-----
> > From: Javeed, Ashraf
> > Sent: Monday, May 27, 2019 6:24 PM
> > To: devel at edk2.groups.io
> > Cc: Javeed, Ashraf <ashraf.javeed at intel.com>; Wang, Jian J
> > <jian.j.wang at intel.com>; Ni, Ray <ray.ni at intel.com>
> > Subject: [PATCH] PciBusDxe: duplicate node insertion for every PPB device
> in
> > the system
> >
> > https://bugzilla.tianocore.org/show_bug.cgi?id=1796
> > Bug fixed in PciBusDxe\PciLib.c.
> > Removed the redundant second call to PciSearchDevice sub-routine when
> > the PCD for the Hot-Plug support is disabled.
> >
> > Signed-off-by: Ashraf Javeed <Ashraf.javeed at intel.com>
> > Cc: Jian J Wang <jian.j.wang at intel.com>
> > Cc: Ray Ni <ray.ni at intel.com>
> > ---
> >  MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c | 19 +------------------
> >  1 file changed, 1 insertion(+), 18 deletions(-)
> >
> > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > index f0d9f45c4a..5b55fb5d3b 100644
> > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > @@ -1114,24 +1114,7 @@ PciScanBus (
> >          //
> >          // For PPB
> >          //
> > -        if (!FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) {
> > -          //
> > -          // If Hot Plug is not supported,
> > -          // get the bridge information
> > -          //
> > -          Status = PciSearchDevice (
> > -                    Bridge,
> > -                    &Pci,
> > -                    StartBusNumber,
> > -                    Device,
> > -                    Func,
> > -                    &PciDevice
> > -                    );
> > -
> > -          if (EFI_ERROR (Status)) {
> > -            return Status;
> > -          }
> > -        } else {
> > +        if (FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) {
> >            //
> >            // If Hot Plug is supported,
> >            // Get the bridge information
> > --
> > 2.21.0.windows.1
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42524): https://edk2.groups.io/g/devel/message/42524
Mute This Topic: https://groups.io/mt/31810004/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-