[edk2-devel] [PATCH 4/7] MdeModulePkg/UefiBootManagerLib: export EfiBootManagerGetBootDescription()

[David Woodhouse]

On Tue, 2019-06-25 at 02:00 +0000, Ni, Ray wrote:
> David,
> I am afraid it will cause issues when exposing EfiBootManagerGetBootDescription().
> If you check the implementation, this API visits mPlatformBootDescriptionHandlers.
> mPlatformBootDescriptionHandlers is modified by another already-exposed API
> EfiBootManagerRegisterBootDescriptionHandler().
> 
> The *Register* API is to provide a capability to PlatformBootManagerLib to create
> boot option description for special/platform-specific boot options.
> 
> But the implicit requirement is boot option description can only be retrieved within
> BdsDxe driver because only BdsDxe driver links to PlatformBootManagerLib.

Hm, I'm not sure I fully understand the reason why the transitive
dependency isn't OK, but neither is are the "special/platform-specific" 
boot options relevant for the CSM boot. So I'm happy to drop that part
from the exported EfiBootManagerGetBootDescription() function and do it
only in the internal BmGetBootDescription().




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42792): https://edk2.groups.io/g/devel/message/42792
Mute This Topic: https://groups.io/mt/32163535/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5174 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20190625/bbb75c1c/attachment.bin>