[edk2-devel] [PATCH v1 1/1] CryptoPkg/OpensslLib: Exclude err_all.c in process_files.py

[Laszlo Ersek]

Jian,

On 06/25/19 10:58, Wang, Jian J wrote:

> I take this as agreement. I pushed this patch at (fixed file ext)
> 
> 51f7a3e6c5192d3f9a0fa63b0b5617c151180ad7

Please pay more attention to the process.

First, you pushed the patch, but the BZ (1881) is still open. You or
XiaoyuX should have closed the BZ with a reference to the commit. I'm
doing that now.

Second, in commit 51f7a3e6c519, you failed to pick up my R-b from the list:

http://mid.mail-archive.com/22434e9b-745c-671c-2b71-43f5ecb49848@redhat.com

My suggestion is, just before you push a patch, go through the entire
mailing list thread for one last time, to make sure no feedback is lost.

(Obviously, if your MUA doesn't offer a threaded view, this is quite
difficult. Even in that case though, you could filter the list folder
for the particular subject, at the least.)

> Above one is in our plan. I added BZ#1936 for this one.
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=1936

That's appreciated.

Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42894): https://edk2.groups.io/g/devel/message/42894
Mute This Topic: https://groups.io/mt/32120631/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-