[edk2-devel] [PATCH] Fix indentation in edksetup.sh SetupPython3

Liming Gao liming.gao at intel.com
Fri Jun 28 08:04:36 UTC 2019


The change is good. Reviewed-by: Liming Gao <liming.gao at intel.com>

I suggest you run this script in Linux and double confirm. 

>-----Original Message-----
>From: devel at edk2.groups.io [mailto:devel at edk2.groups.io] On Behalf Of
>rebecca at bluestop.org
>Sent: Thursday, June 27, 2019 9:05 PM
>To: Gao, Liming <liming.gao at intel.com>; devel at edk2.groups.io; Feng, Bob C
><bob.c.feng at intel.com>; Fan, ZhijuX <zhijux.fan at intel.com>
>Subject: Re: [edk2-devel] [PATCH] Fix indentation in edksetup.sh
>SetupPython3
>
>On 2019-06-27 01:37, Gao, Liming wrote:
>> So, this is just indentation update. There is no functionality impact. What
>test have you done?
>
>
>Yes, it's just whitespace changes. I haven't done any tests, since
>whitespace doesn't affect functionality.
>
>Running "git diff -w" confirms there are no functionality changes.
>
>
>--
>Rebecca Cran
>
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42993): https://edk2.groups.io/g/devel/message/42993
Mute This Topic: https://groups.io/mt/32217032/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-





More information about the edk2-devel-archive mailing list