[edk2-devel] May I become a contributor in EmulatorPkg ?
Hiber He
hiberhe at 163.com
Sun Jun 30 23:13:37 UTC 2019
Hi,
(Sorry for the previous incomplete email!)
For the second one: Dai already pointed out the problem, a ending slash(\) should be added to the nasm path variable. You can find the how nasm path is processed in edksetup.bat:
:check_NASM
if not defined NASM_PREFIX (
@echo.
@echo !!! WARNING !!! NASM_PREFIX environment variable is not set
@if exist "C:\nasm\nasm.exe" @set "NASM_PREFIX=C:\nasm\"
@if exist "C:\nasm\nasm.exe" @echo Found nasm.exe, setting the environment variable to C:\nasm\
@if not exist "C:\nasm\nasm.exe" echo Attempting to build modules that require NASM will fail.
)
And iasl path variable(IASL_PREFIX) is handled similarly. Maybe they should be adopted to handle with and without ending slash(\).
Best Regards,
Hiber
On 06/30/2019 21:22, Ni, Ray wrote:
Bob,
Any comments?
From:戴,曉政 [mailto:cloud0907 at yahoo.com.tw]
Sent: Sunday, June 30, 2019 3:37 PM
To: Justen, Jordan L <jordan.l.justen at intel.com>; afish at apple.com; Ni, Ray <ray.ni at intel.com>
Subject: May I become a contributor in EmulatorPkg ?
Dears,
I live in Taiwan so please forgive my English pool. I download edk2 source code from Github recently and I encounter two build error when I build EmulatorPkg (I use Visual Studio 2017 ). First is in GenPcdDb.py, this error means parameter used to unpack is zero, please refer below :
Second is in tools_def.txt, this error means there is missing slash before nasm.exe, please refer below :
You can search “clouddai-test” in Attachment so that you will easy understand what I say. If I need submit more official document for become a contributor please let me know, or if my modification need obey some rule please also let me know, I am waiting your response
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43055): https://edk2.groups.io/g/devel/message/43055
Mute This Topic: https://groups.io/mt/32260944/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20190701/7c95964b/attachment.htm>
More information about the edk2-devel-archive
mailing list