[edk2-devel] [PATCH V3 0/8] Update SMBIOS 3.3.0

[Ni, Ray]

Zhichao,
I took a  look at the patch 5/8.
Given the value is already defined in MdePkg header file, can you please
update the implementation to avoid using magic number?

I suggest you do the code change in two parts: one patch to modify existing
magic numbers to use macros/enums defined in MdePkg, the other patch
to add new mappings without using magic numbers.

I didn't check the other patches after 5/8. If there are magic numbers as well,
can you please update them as well?

Thanks,
Ray
> -----Original Message-----
> From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Gao,
> Zhichao
> Sent: Thursday, November 7, 2019 8:52 AM
> To: devel at edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney at intel.com>; Gao, Liming
> <liming.gao at intel.com>; Ni, Ray <ray.ni at intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty at intel.com>
> Subject: [edk2-devel] [PATCH V3 0/8] Update SMBIOS 3.3.0
> 
> The following changes were made to version 3.2.0 of the document to
> produce this
> version:
> • System Slots (Type 9):
> – Add PCI Express Gen 4 values
> – Clarify bus number usage for PCI Express • Memory Device (Type 17):
> – Add new memory device type value (HBM) and new form factor value (Die)
> – Update the string for Intel persistent memory • Various:
> – Add support for RISC-V processors, add structure type 44 (processor-
> additional information) – add support for CXL Flexbus
> 
> V2:
> Add the new definition to MdePkg/Smbios.h.
> 
> V3:
> Avoid change the enum name to casue the incompatible issue.
> Add the comment instead change the enum define name.
> 
> Notes:
> Clarify bus number usage for PCI Express - Update the spec no code change
> requirement Add support for RISC-V processors, add structure type 44
> (processor-additional information) - Already done at
> https://bugzilla.tianocore.org/show_bug.cgi?id=2202
> 
> Cc: Michael D Kinney <michael.d.kinney at intel.com>
> Cc: Liming Gao <liming.gao at intel.com>
> Cc: Ray Ni <ray.ni at intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty at intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao at intel.com>
> 
> Zhichao Gao (8):
>   MdePkg/Smbios.h: SMBIOS 3.3.0 add PCI gen4 values for type 9
>   MdePkg/Smbios.h: SMBIOS 3.3.0 add support for CXL Flexbus
>   MdePkg/Smbios.h: SMBIOS 3.3.0 Add value HBM and Die for type 17
>   MdePkg/Smbios.h: SMBIOS 3.3.0 Update Intel Persistent Memory string
>   ShellPkg/SmbiosView: SMBIOS 3.3.0 add PCI gen4 values for type 9
>   ShellPkg/SmbiosView: SMBIOS 3.3.0 add support for CXL Flexbus
>   ShellPkg/SmbiosView: SMBIOS 3.3.0 Add value HBM and Die for type 17
>   ShellPkg/SmbiosView: SMBIOS 3.3.0 Update "Intel persistent memory"
> 
>  MdePkg/Include/IndustryStandard/SmBios.h           | 25 ++++++++---
>  .../SmbiosView/QueryTable.c                        | 48 +++++++++++++++++++++-
>  2 files changed, 66 insertions(+), 7 deletions(-)
> 
> --
> 2.16.2.windows.1
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#50284): https://edk2.groups.io/g/devel/message/50284
Mute This Topic: https://groups.io/mt/44839633/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-