[edk2-devel] EDK II Maintainers please test the pull request commit gate

[Michael D Kinney]

Phil,

Yes.  There are two methods available

1) You can run the CI tests on your local dev system.
   Fix issues locally and rerun as needed before sending
   patch review email.  This will only perform build
   tests with your local compiler.

2) You can push a branch with changes to your personal
   fork of the edk2 repository (edk2-staging in the
   review period) and submit a pull request to the
   tianocore repo *without* the 'push' label set .  This
   is considered a personal build.  If all CI checks pass
   then the PR is auto closed with a comment on the
   PR.  If the PR fails, then the PR is left open with
   comment on the PR.  In the failure case, you can fix
   the issue on your local branch and do a forced
   push to your personal fork.  GitHub sees the forced
   push and reruns the CI tests automatically.  Today
   this runs build tests for VS2019 and GCC, so you get
   better coverage than local testing.  Once your personal
   build passes, you can send patch review email and can
   even point to the PR for your personal build so 
   reviewers and maintainers can view the CI results.

NOTE: (1) does not send any public emails.
      (2) will send a public email when a comment or
          close action is performed on a PR to all
          GitHub users that are watching that repo.

Best regards,

Mike


> -----Original Message-----
> From: Philippe Mathieu-Daudé <philmd at redhat.com>
> Sent: Friday, November 8, 2019 6:49 AM
> To: Kinney, Michael D <michael.d.kinney at intel.com>
> Cc: devel at edk2.groups.io
> Subject: Re: [edk2-devel] EDK II Maintainers please test
> the pull request commit gate
> 
> Hi Michael,
> 
> On 11/7/19 3:24 AM, Michael D Kinney wrote:
> > EDK II Maintainers,
> >
> > Please take a few minutes to test the GitHub pull
> request commit gate
> > feature under review in the edk2-staging/edk2-ci
> branch.  This will be
> > the only method to push patches to the edk2 repo in
> the near future,
> > and we want all current EDK II Maintainers to make
> sure they know how
> > to use this new process on the edk2-staging repo
> before it is
> > activated on the
> > edk2 repo.
> [...]
> 
> Is it possible to use the CI gating scripts on an
> individual fork when working on a new feature, so if the
> CI system catches bugs we can fix them before bothering
> the mailing list and maintainers for review?
> 
> Thanks,
> 
> Phil.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#50309): https://edk2.groups.io/g/devel/message/50309
Mute This Topic: https://groups.io/mt/44980130/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-