[edk2-devel] [PATCH edk2-platforms v2 3/8] Platform/Overdrive: fix a typo in the DT

Leif Lindholm via Groups.Io leif.lindholm=linaro.org at groups.io
Thu Nov 28 12:32:00 UTC 2019


On Wed, Nov 27, 2019 at 19:44:34 +0100, Ard Biesheuvel wrote:
> DT unit addresses are hex quantities but they should not include
> the 0x prefix.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>

Reviewed-by: Leif Lindholm <leif.lindholm at linaro.org>

But can you clarify in commit message that this is a cosmetic/style
change only?

(And maybe mirror this cleanup in
Platform/SoftIron/Overdrive1000Board/FdtBlob/styx-overdrive1000.dts
? These appear to be the only two instances in the repo.)

/
    Leif

> ---
>  Platform/AMD/OverdriveBoard/DeviceTree/OverdriveBoard.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Platform/AMD/OverdriveBoard/DeviceTree/OverdriveBoard.dts b/Platform/AMD/OverdriveBoard/DeviceTree/OverdriveBoard.dts
> index 1d8a6caafd82..a92ab695fb2e 100644
> --- a/Platform/AMD/OverdriveBoard/DeviceTree/OverdriveBoard.dts
> +++ b/Platform/AMD/OverdriveBoard/DeviceTree/OverdriveBoard.dts
> @@ -291,7 +291,7 @@
>  			dma-coherent;
>  		};
>  
> -		ccn at 0xe8000000 {
> +		ccn at e8000000 {
>  			compatible = "arm,ccn-504";
>  			reg = <0x0 0xe8000000 0x0 0x1000000>;
>  			interrupts = <0x0 0x17c 0x4>;
> -- 
> 2.17.1
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51449): https://edk2.groups.io/g/devel/message/51449
Mute This Topic: https://groups.io/mt/62736828/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-





More information about the edk2-devel-archive mailing list