[edk2-devel] [edk2-platforms][PATCH V2 27/47] WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Add PEI_ARCH and DXE_ARCH

[Chiu, Chasel via Groups.Io]

Reviewed-by: Chasel Chiu <chasel.chiu at intel.com>


> -----Original Message-----
> From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Kubacki,
> Michael A
> Sent: Thursday, November 28, 2019 9:06 AM
> To: devel at edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu at intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone at intel.com>
> Subject: [edk2-devel] [edk2-platforms][PATCH V2 27/47]
> WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Add PEI_ARCH and DXE_ARCH
> 
> This change adds two new macros to OpenBoardPkg.dsc that identify the
> build architecture for PEI and DXE modules. The intention of this macro is to
> ensure that all DSC files that compose the package build (such as those
> included from MinPlatformPkg or an advanced feature package) build
> phase-specific drivers for the architecture defined by the board package.
> 
> This is a macro that is required in all Minimum Platform board packages.
> 
> Cc: Chasel Chiu <chasel.chiu at intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone at intel.com>
> Signed-off-by: Michael Kubacki <michael.a.kubacki at intel.com>
> Reviewed-by: Nate DeSimone <nathaniel.l.desimone at intel.com>
> ---
> 
> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.
> dsc | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
> kg.dsc
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
> kg.dsc
> index 127147c734..ae3fec05ed 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
> kg.dsc
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
> k
> +++ g.dsc
> @@ -15,6 +15,8 @@
>    DEFINE      PLATFORM_BOARD_PACKAGE    =
> WhiskeylakeOpenBoardPkg
>    DEFINE      BOARD                     = WhiskeylakeURvp
>    DEFINE      PROJECT                   =
> $(PLATFORM_BOARD_PACKAGE)/$(BOARD)
> +  DEFINE      PEI_ARCH                  = IA32
> +  DEFINE      DXE_ARCH                  = X64
> 
>    #
>    # Include PCD configuration for this board.
> @@ -73,10 +75,14 @@
>  #######################################
>  # Component Includes
>  #######################################
> +# @todo: Change below line to [Components.$(PEI_ARCH)] after
> https://bugzilla.tianocore.org/show_bug.cgi?id=2308
> +#        is completed
>  [Components.IA32]
>  !include $(PLATFORM_PACKAGE)/Include/Dsc/CorePeiInclude.dsc
>  !include $(PLATFORM_SI_PACKAGE)/SiPkgPei.dsc
> 
> +# @todo: Change below line to [Components.$(DXE_ARCH)] after
> https://bugzilla.tianocore.org/show_bug.cgi?id=2308
> +#        is completed
>  [Components.X64]
>  !include $(PLATFORM_PACKAGE)/Include/Dsc/CoreDxeInclude.dsc
>  !include $(PLATFORM_SI_PACKAGE)/SiPkgDxe.dsc
> @@ -260,6 +266,11 @@
> 
> TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLib/S
> mmTestPointCheckLib.inf
>  !endif
> 
> +#######################################
> +# PEI Components
> +#######################################
> +# @todo: Change below line to [Components.$(PEI_ARCH)] after
> https://bugzilla.tianocore.org/show_bug.cgi?id=2308
> +#        is completed
>  [Components.IA32]
>    #######################################
>    # Edk2 Packages
> @@ -330,6 +341,11 @@
>  !endif
>    $(PLATFORM_BOARD_PACKAGE)/BiosInfo/BiosInfo.inf
> 
> +#######################################
> +# DXE Components
> +#######################################
> +# @todo: Change below line to [Components.$(DXE_ARCH)] after
> https://bugzilla.tianocore.org/show_bug.cgi?id=2308
> +#        is completed
>  [Components.X64]
>    #######################################
>    # Edk2 Packages
> --
> 2.16.2.windows.1
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51489): https://edk2.groups.io/g/devel/message/51489
Mute This Topic: https://groups.io/mt/63459061/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-