[edk2-devel] [edk2-platforms][PATCH V2 37/47] WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Enable advanced features
Chiu, Chasel via Groups.Io
chasel.chiu=intel.com at groups.io
Fri Nov 29 07:02:02 UTC 2019
Reviewed-by: Chasel Chiu <chasel.chiu at intel.com>
> -----Original Message-----
> From: Kubacki, Michael A <michael.a.kubacki at intel.com>
> Sent: Thursday, November 28, 2019 9:06 AM
> To: devel at edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu at intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone at intel.com>
> Subject: [edk2-platforms][PATCH V2 37/47]
> WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Enable advanced features
>
> This change enables advanced features to be used by the WhiskeylakeURvp
> board in WhiskeylakeOpenBoardPkg.
>
> Some platform macros in OpenBoardPkg.dsc are consolidated so all values
> are set at the top of the file before including advanced feature code.
>
> Cc: Chasel Chiu <chasel.chiu at intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone at intel.com>
> Signed-off-by: Michael Kubacki <michael.a.kubacki at intel.com>
> Reviewed-by: Nate DeSimone <nathaniel.l.desimone at intel.com>
> ---
>
> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.
> dsc | 44 +++++++++-----------
>
> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg
> Pcd.dsc | 1 +
>
> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.
> fdf | 4 ++
> 3 files changed, 25 insertions(+), 24 deletions(-)
>
> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
> kg.dsc
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
> kg.dsc
> index ae3fec05ed..47e156be08 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
> kg.dsc
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
> k
> +++ g.dsc
> @@ -17,36 +17,32 @@
> DEFINE PROJECT =
> $(PLATFORM_BOARD_PACKAGE)/$(BOARD)
> DEFINE PEI_ARCH = IA32
> DEFINE DXE_ARCH = X64
> -
> - #
> - # Include PCD configuration for this board.
> - #
> - !include OpenBoardPkgPcd.dsc
> -
> -###############################################################
> #################
> -#
> -# Defines Section - statements that will be processed to create a Makefile.
> -#
> -###############################################################
> #################
> -[Defines]
> - PLATFORM_NAME = $(PLATFORM_PACKAGE)
> - PLATFORM_GUID =
> 84D0F5BD-0EF3-4CC0-9B09-F2D0F2AA5C5E
> - PLATFORM_VERSION = 0.1
> - DSC_SPECIFICATION = 0x00010005
> - OUTPUT_DIRECTORY = Build/$(PROJECT)
> - SUPPORTED_ARCHITECTURES = IA32|X64
> - BUILD_TARGETS = DEBUG|RELEASE
> - SKUID_IDENTIFIER = ALL
> - FLASH_DEFINITION =
> $(PROJECT)/OpenBoardPkg.fdf
> -
> - FIX_LOAD_TOP_MEMORY_ADDRESS = 0x0
> - DEFINE TOP_MEMORY_ADDRESS = 0x0
> + DEFINE TOP_MEMORY_ADDRESS = 0x0
>
> #
> # Default value for OpenBoardPkg.fdf use
> #
> DEFINE BIOS_SIZE_OPTION = SIZE_70
>
> + PLATFORM_NAME = $(PLATFORM_PACKAGE)
> + PLATFORM_GUID =
> 84D0F5BD-0EF3-4CC0-9B09-F2D0F2AA5C5E
> + PLATFORM_VERSION = 0.1
> + DSC_SPECIFICATION = 0x00010005
> + OUTPUT_DIRECTORY = Build/$(PROJECT)
> + SUPPORTED_ARCHITECTURES = IA32|X64
> + BUILD_TARGETS = DEBUG|RELEASE
> + SKUID_IDENTIFIER = ALL
> +
> + FLASH_DEFINITION =
> $(PROJECT)/OpenBoardPkg.fdf
> + FIX_LOAD_TOP_MEMORY_ADDRESS = 0x0
> +
> + #
> + # Include PCD configuration for this board.
> + #
> + !include
> +
> AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaro
> und.d
> + sc
> + !include OpenBoardPkgPcd.dsc
> + !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
> +
>
> ################################################################
> ################
> #
> # SKU Identification section - list of all SKU IDs supported by this board.
> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
> kgPcd.dsc
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
> kgPcd.dsc
> index 52471cb25b..906f7b7ade 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
> kgPcd.dsc
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
> k
> +++ gPcd.dsc
> @@ -24,6 +24,7 @@
> # Stage 3 - boot to shell only
> # Stage 4 - boot to OS
> # Stage 5 - boot to OS with security boot enabled
> + # Stage 6 - boot with advanced features enabled
> #
> gMinPlatformPkgTokenSpaceGuid.PcdBootStage|4
>
> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
> kg.fdf
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
> kg.fdf
> index 130930ad40..f39b41b186 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
> kg.fdf
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
> k
> +++ g.fdf
> @@ -623,6 +623,8 @@ READ_LOCK_CAP = TRUE
> READ_LOCK_STATUS = TRUE
> FvNameGuid = 6053D78A-457E-4490-A237-31D0FBE2F305
>
> +!include AdvancedFeaturePkg/Include/PreMemory.fdf
> +
> !if gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdTbtEnable == TRUE
> INF $(PLATFORM_BOARD_PACKAGE)/Features/Tbt/TbtInit/Pei/PeiTbtInit.inf
> !endif
> @@ -649,6 +651,8 @@ READ_LOCK_CAP = TRUE
> READ_LOCK_STATUS = TRUE
> FvNameGuid = BE3DF86F-E464-44A3-83F7-0D27E6B88C27
>
> +!include AdvancedFeaturePkg/Include/PostMemory.fdf
> +
> !if gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdTbtEnable == TRUE
> INF $(PLATFORM_BOARD_PACKAGE)/Features/Tbt/TbtInit/Dxe/TbtDxe.inf
> INF $(PLATFORM_BOARD_PACKAGE)/Features/PciHotPlug/PciHotPlug.inf
> --
> 2.16.2.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#51498): https://edk2.groups.io/g/devel/message/51498
Mute This Topic: https://groups.io/mt/63460269/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list