[edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 09/29] MdePkg/BaseIoLibIntrinsic: RISC-V I/O intrinsic functions.

[Leif Lindholm]

On Tue, Oct 01, 2019 at 10:49:38AM +0200, Philippe Mathieu-Daudé wrote:
> Hi Leif,
> 
> On 9/27/19 1:39 AM, Leif Lindholm wrote:
> > On Mon, Sep 23, 2019 at 08:31:35AM +0800, Abner Chang wrote:
> > > RISC-V MMIO library instance.  RISC-V only supports memory map I/O.
> > 
> > We need fewer, not more, C implementations of MMIO accessors.
> > While this set doesn't need to wait for upstream to get sorted, please
> > just use IoLibArm.c which should be completely equivalent to what you
> > have implemented here.
> 
> This shows this file name is misleading. However I can't come with a clever
> one :/

This has been discussed before, only the current situation "works", so
sorting it out never takes priority (I know it doesn't for me).

There should be exactly one variant of IoLib.c. Well, these days we
need a separate one for ARM/AARCH64 under hw virtualization.

IoLibArm, IoLibEbc and IoLibRiscV have *exactly* the same
requirements. And now x86 uses NASM regardless of build platform, I
think it would make sense to move the contents of IoLibGcc and
IoLibMsc into assembler.

/
    Leif

> > > Signed-off-by: Abner Chang <abner.chang at hpe.com>
> > > ---
> > >   .../BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf      |   8 +-
> > >   MdePkg/Library/BaseIoLibIntrinsic/IoLibRiscV.c     | 601 +++++++++++++++++++++
> > >   2 files changed, 607 insertions(+), 2 deletions(-)
> > >   create mode 100644 MdePkg/Library/BaseIoLibIntrinsic/IoLibRiscV.c

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#48341): https://edk2.groups.io/g/devel/message/48341
Mute This Topic: https://groups.io/mt/34258203/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-