[edk2-devel] [PATCH 18/35] NetworkPkg/DxeNetLib: fix type typo in NetLibGetMacAddress()

[Siyuan, Fu]

Just return from vacation. Sorry for late response.

Reviewed-by: Siyuan Fu <siyuan.fu at intel.com>

> -----Original Message-----
> From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Philippe
> Mathieu-Daudé
> Sent: 2019年9月24日 19:00
> To: devel at edk2.groups.io; lersek at redhat.com
> Cc: Wu, Jiaxin <jiaxin.wu at intel.com>; Fu, Siyuan <siyuan.fu at intel.com>
> Subject: Re: [edk2-devel] [PATCH 18/35] NetworkPkg/DxeNetLib: fix type
> typo in NetLibGetMacAddress()
> 
> On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> > NetLibGetSnpHandle() returns an EFI_HANDLE, not an (EFI_HANDLE*).
> > NetLibGetMacAddress() only uses the return value ("SnpHandle") for a
> > NULL-check. Fix the type of "SnpHandle".
> >
> > This patch is a no-op.
> >
> > Cc: Jiaxin Wu <jiaxin.wu at intel.com>
> > Cc: Siyuan Fu <siyuan.fu at intel.com>
> > Signed-off-by: Laszlo Ersek <lersek at redhat.com>
> > ---
> >
> > Notes:
> >     lightly tested: MAC strings are displayed in UiApp
> >
> >  NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> > index 8e2f720666ea..a39c20be3d34 100644
> > --- a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> > +++ b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> > @@ -2182,7 +2182,7 @@ NetLibGetMacAddress (
> >    EFI_SIMPLE_NETWORK_MODE      SnpModeData;
> >    EFI_MANAGED_NETWORK_PROTOCOL *Mnp;
> >    EFI_SERVICE_BINDING_PROTOCOL *MnpSb;
> > -  EFI_HANDLE                   *SnpHandle;
> > +  EFI_HANDLE                   SnpHandle;
> >    EFI_HANDLE                   MnpChildHandle;
> >
> >    ASSERT (MacAddress != NULL);
> >
> 
> Since SnpHandle is only checked for being non-null, this change is
> indeed a no-op, else it would probably fixed some bug.
> 
> Reviewed-by: Philippe Mathieu-Daude <philmd at redhat.com>
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#48511): https://edk2.groups.io/g/devel/message/48511
Mute This Topic: https://groups.io/mt/34180219/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-