[edk2-devel] [edk2-platforms][PATCH V1 00/17] Intel Board Package Cleanup

Kubacki, Michael A michael.a.kubacki at intel.com
Tue Oct 8 05:16:28 UTC 2019


This patch series affects the following packages/boards.
 1. KabylakeOpenBoardPkg/KabylakeRvp3
 2. KabylakeOpenBoardPkg/GalagoPro3
 3. WhiskeylakeOpenBoardPkg/WhiskeylakeURvp
 4. SimicsOpenBoardPkg/BoardX58Ich10

The following high-level changes are done for each board.
 1. Remove the file OpenBoardPkgConfig.dsc
    The file contents are merged into OpenBoardPkgPcd.dsc.

 2. Make the order and location of DSC files included into
    OpenBoardPkg.dsc consistent across all boards.

 3. Refactor OpenBoardPkg.dsc and OpenBoardPkgPcd.dsc such that
    duplicate sections are consolidated, duplicate PCDs are cleaned
    up, and a consistent format is applied across the files improving
    maintainability and readability.

 4. Assign a unique PCD token namespace string and value for each board
    package.

Cc: Sai Chaganty <rangasai.v.chaganty at intel.com>
Cc: Chasel Chiu <chasel.chiu at intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone at intel.com>
Cc: Agyeman Prince <prince.agyeman at intel.com>
Cc: Jeremy Soller <jeremy at system76.com>
Cc: Wei David Y <david.y.wei at intel.com>
Signed-off-by: Michael Kubacki <michael.a.kubacki at intel.com>

Michael Kubacki (17):
  KabylakeOpenBoardPkg/KabylakeRvp3: Remove OpenBoardPkgConfig.dsc
  KabylakeSiliconPkg: Add DSC include file section tags
  KabylakeOpenBoardPkg/KabylakeRvp3: DSC cleanup
  KabylakeOpenBoardPkg/GalagoPro3: Relocate PCD DSC include
  KabylakeOpenBoardPkg/GalagoPro3: Remove OpenBoardPkgConfig.dsc
  KabylakeOpenBoardPkg/GalagoPro3: DSC cleanup
  KabylakeOpenBoardPkg: Assign unique token namespace
  WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Relocate PCD DSC include
  WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Remove OpenBoardPkgConfig.dsc
  CoffeelakeSiliconPkg: Add DSC include file section tags
  WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Update FSP base PCDs
  WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: DSC cleanup
  WhiskeylakeOpenBoardPkg: Assign unique token namespace
  SimicsOpenBoardPkg/BoardX58Ich10: Relocate DSC includes
  SimicsOpenBoardPkg/BoardX58Ich10: Remove OpenBoardPkgConfig.dsc
  SimicsOpenBoardPkg/BoardX58Ich10: DSC cleanup
  SimicsOpenBoardPkg: Assign unique token namespace

 Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec                                                                              | 408 ++++++------
 Platform/Intel/SimicsOpenBoardPkg/OpenBoardPkg.dec                                                                                |  72 +--
 Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec                                                                           | 684 ++++++++++----------
 Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc                                                                   | 488 +++++++-------
 Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgConfig.dsc                                                             | 132 ----
 Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.dsc                                                                | 438 +++++++++----
 Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc                                                                 | 520 ++++++++-------
 Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig.dsc                                                           | 138 ----
 Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc                                                              | 467 ++++++++-----
 Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc                                                                  | 296 +++++----
 Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgConfig.dsc                                                            |  56 --
 Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc                                                               | 433 +++++++------
 Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc                                                           | 509 ++++++++-------
 Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkgConfig.dsc                                                     | 128 ----
 Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkgPcd.dsc                                                        | 395 +++++++----
 Silicon/Intel/CoffeelakeSiliconPkg/SiPkgCommonLib.dsc                                                                             |   1 +
 Silicon/Intel/CoffeelakeSiliconPkg/SiPkgDxeLib.dsc                                                                                |   1 +
 Silicon/Intel/CoffeelakeSiliconPkg/SiPkgPeiLib.dsc                                                                                |   1 +
 Silicon/Intel/KabylakeSiliconPkg/SiPkgCommonLib.dsc                                                                               |   6 +-
 Silicon/Intel/KabylakeSiliconPkg/SiPkgDxeLib.dsc                                                                                  |   5 +-
 Silicon/Intel/KabylakeSiliconPkg/SiPkgPeiLib.dsc                                                                                  |   3 +-
 Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/Fdf/FlashMapInclude.fdf                                                    |   4 +-
 Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf                                                                   |   8 +-
 Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf                                                                 |   4 +-
 Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf                                                                  |  12 +-
 Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.fdf                                                           |   7 +-
 Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf                                                            |  16 +-
 Platform/Intel/KabylakeOpenBoardPkg/Features/PciHotPlug/PciHotPlug.inf                                                            |   4 +-
 Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/Library/DxeTbtPolicyLib/DxeTbtPolicyLib.inf                                      |  40 +-
 Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/Library/PeiDxeSmmTbtCommonLib/TbtCommonLib.inf                                   |  40 +-
 Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/Library/PeiTbtPolicyLib/PeiTbtPolicyLib.inf                                      |  18 +-
 Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/TbtSmm.inf                                                           |   4 +-
 Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/PeiSiliconPolicyNotifyLib/PeiPreMemSiliconPolicyNotifyLib.inf              |   8 +-
 Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/FspWrapper/Library/PeiSiliconPolicyNotifyLib/PeiPreMemSiliconPolicyNotifyLib.inf   |   8 +-
 Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf   |  70 +-
 Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BasePlatformHookLib/BasePlatformHookLib.inf                                |  18 +-
 Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/DxeBoardAcpiTableLib.inf                                      |   4 +-
 Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/DxeMultiBoardAcpiSupportLib.inf                               |  10 +-
 Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/SmmBoardAcpiEnableLib.inf                                     |   2 +-
 Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/SmmMultiBoardAcpiSupportLib.inf                               |   2 +-
 Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/PeiBoardInitPostMemLib.inf                                    |  16 +-
 Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/PeiBoardInitPreMemLib.inf                                     | 134 ++--
 Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/PeiMultiBoardInitPostMemLib.inf                               |  16 +-
 Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/PeiMultiBoardInitPreMemLib.inf                                | 132 ++--
 Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Policy/Library/DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.inf             |   4 +-
 Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf |  74 +--
 Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BasePlatformHookLib/BasePlatformHookLib.inf                              |  18 +-
 Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/DxeBoardAcpiTableLib.inf                                    |  12 +-
 Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/DxeMultiBoardAcpiSupportLib.inf                             |  14 +-
 Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/SmmBoardAcpiEnableLib.inf                                   |   6 +-
 Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/SmmMultiBoardAcpiSupportLib.inf                             |   6 +-
 Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/PeiBoardInitPostMemLib.inf                                  |  18 +-
 Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/PeiBoardInitPreMemLib.inf                                   | 134 ++--
 Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/PeiMultiBoardInitPostMemLib.inf                             |  18 +-
 Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/PeiMultiBoardInitPreMemLib.inf                              | 136 ++--
 Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Policy/Library/DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.inf           |   6 +-
 Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Policy/Library/PeiSiliconPolicyUpdateLib/PeiSiliconPolicyUpdateLib.inf           |  54 +-
 Platform/Intel/KabylakeOpenBoardPkg/Library/PeiSerialPortLibSpiFlash/PeiSerialPortLibSpiFlash.inf                                 |   4 +-
 Platform/Intel/SimicsOpenBoardPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf                                                   |  14 +-
 Platform/Intel/SimicsOpenBoardPkg/Library/PeiReportFvLib/PeiReportFvLib.inf                                                       |  10 +-
 Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf                                       |  10 +-
 Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf                                                                             |  18 +-
 Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf                                                                         |  36 +-
 Platform/Intel/SimicsOpenBoardPkg/SimicsVideoDxe/SimicsVideoDxe.inf                                                               |   2 +-
 Platform/Intel/WhiskeylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf                                                         |  14 +-
 Platform/Intel/WhiskeylakeOpenBoardPkg/Features/Tbt/Library/PeiDxeSmmTbtCommonLib/TbtCommonLib.inf                                |  26 +-
 Platform/Intel/WhiskeylakeOpenBoardPkg/Features/Tbt/Library/PeiTbtPolicyLib/PeiTbtPolicyLib.inf                                   |   2 +-
 Platform/Intel/WhiskeylakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/TbtSmm.inf                                                        |   2 +-
 Platform/Intel/WhiskeylakeOpenBoardPkg/FspWrapper/Library/PeiFspPolicyInitLib/PeiFspPolicyInitLib.inf                             |  22 +-
 Platform/Intel/WhiskeylakeOpenBoardPkg/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf           |  64 +-
 Platform/Intel/WhiskeylakeOpenBoardPkg/Library/PeiHdaVerbTableLib/PeiHdaVerbTableLib.inf                                          |  14 +-
 Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdateLib/PeiPolicyUpdateLib.inf                                   | 280 ++++----
 Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/PolicyInitDxe/PolicyInitDxe.inf                                                     | 164 ++---
 Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BasePlatformHookLib/BasePlatformHookLib.inf                        |  12 +-
 Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmBoardAcpiEnableLib.inf                             |   2 +-
 Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmMultiBoardAcpiSupportLib.inf                       |   2 +-
 Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardInitLib/PeiBoardInitPostMemLib.inf                            |  14 +-
 Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardInitLib/PeiBoardInitPreMemLib.inf                             | 112 ++--
 Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardInitLib/PeiMultiBoardInitPostMemLib.inf                       | 214 +++---
 Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardInitLib/PeiMultiBoardInitPreMemLib.inf                        | 316 ++++-----
 Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/PeiPlatformHookLib/PeiPlatformHooklib.inf                          |  66 +-
 Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/DecomprScratchEnd.fdf.inc                                                         |   6 +-
 Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf.inc                                                              |  16 +-
 83 files changed, 3910 insertions(+), 3790 deletions(-)
 delete mode 100644 Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgConfig.dsc
 delete mode 100644 Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig.dsc
 delete mode 100644 Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgConfig.dsc
 delete mode 100644 Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkgConfig.dsc

-- 
2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#48528): https://edk2.groups.io/g/devel/message/48528
Mute This Topic: https://groups.io/mt/34439434/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-




More information about the edk2-devel-archive mailing list