[edk2-devel] [Patch 12/12] OvmfPkg SecMain: Add build option "-fno-omit-frame-pointer" for CLANG9 X64

[Laszlo Ersek]

On 10/11/19 03:30, Liming Gao wrote:
> Laszlo:
> 
>> -----Original Message-----
>> From: Laszlo Ersek [mailto:lersek at redhat.com]
>> Sent: Friday, October 11, 2019 1:35 AM
>> To: devel at edk2.groups.io; Gao, Liming <liming.gao at intel.com>; Justen,
>> Jordan L <jordan.l.justen at intel.com>
>> Subject: Re: [edk2-devel] [Patch 12/12] OvmfPkg SecMain: Add build option "-
>> fno-omit-frame-pointer" for CLANG9 X64
>>
>> Hi Liming,
>>
>> On 10/10/19 16:08, Liming Gao wrote:
>>> Laszlo:
>>>   Option (a) works. Jordan patch can fix this issue.
>>>   Option (b) doesn't work. Even if disable optimization, CLANG doesn't
>> generate the code with push rbp & pop rbp.
>>>
>>>   So, Jordan patch becomes only option. We can discuss this topic again. But,
>> I don't think this is the block issue
>>>   to add new CLANG9 tool chain. I will try to add CLANG9 tool chain patch
>> without this change, and use BZ 2024 to track this issue.
>>
>> not sure I understand you correctly.
>>
>> - If you intend to drop this patch from the series, and enable CLANG9
>> for edk2 without enabling it for OvmfPkg specifically (for the time
>> being), that's fine with me.
>>
> I mean to drop this patch from this patch set. I will use BZ 2024 to track this issue.
> Without this fix, CLANG9 OVMF X64 boot will hang. CLANG9 OVMF Ia32 and Ia32X64 boots fine.

OK, thank you.
Laszlo

>> - If you'd like to push this patch first, and work on the general PEI
>> Core issue second, then I defer to Jordan for reviewing this patch. I'd
>> like to neither approve nor reject this patch myself, in that case.
>>
>> Thanks
>> Laszlo
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#48810): https://edk2.groups.io/g/devel/message/48810
Mute This Topic: https://groups.io/mt/34309065/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-